Closed
Bug 1322723
Opened 8 years ago
Closed 7 years ago
Show the default browser prompt on *second* startup for the feb 2017 funnelcake
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 53
People
(Reporter: Gijs, Assigned: dao)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: pref: browser.shell.skipDefaultBrowserCheckOnFirstRun = true)
Attachments
(1 file)
4.58 KB,
patch
|
jaws
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This miiight just be flipping a pref to get the nightly behaviour (which IIRC doesn't show it on first startup).
Reporter | ||
Comment 1•8 years ago
|
||
We should also make sure we keep showing it if the default browser changes after the user has made Firefox the default.
Summary: Don't show the default browser prompt on first startup for the feb 2017 funnelcake → Show the default browser prompt on *second* startup for the feb 2017 funnelcake
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dao+bmo
Assignee | ||
Comment 2•7 years ago
|
||
This code is incredibly ugly and unpleasant to work with. I hope I got this right. New pref to be set for the funnelcake build: browser.shell.skipDefaultBrowserCheckOnFirstRun
Attachment #8820539 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8820539 [details] [diff] [review] patch Review of attachment 8820539 [details] [diff] [review]: ----------------------------------------------------------------- Why can't we reuse the skipDefaultBrowserCheck mechanism which AFAICT already does this? I suspect Jared will be a better reviewer here.
Attachment #8820539 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 4•7 years ago
|
||
browser.shell.skipDefaultBrowserCheck is one of those confusing parts of this code. Apparently it's just there for keeping record of whether we're performing the first run. That's why it's already set to 'true' for all builds.
Assignee | ||
Updated•7 years ago
|
Attachment #8820539 -
Flags: review?(jaws)
Reporter | ||
Comment 5•7 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #4) > browser.shell.skipDefaultBrowserCheck is one of those confusing parts of > this code. Apparently it's just there for keeping record of whether we're > performing the first run. That's why it's already set to 'true' for all > builds. So we could reuse it rather than adding another pref, no? We could just edit the code so only the count stuff is behind the !BETA_OR_RELEASE check, and then flip the default value for the pref to false on !BETA_OR_RELEASE, flipping it to true on the funnelcake. That seems cleaner to me than adding yet another pref here.
Comment 6•7 years ago
|
||
Comment on attachment 8820539 [details] [diff] [review] patch Review of attachment 8820539 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, this code is hairy and ugly. I'm OK with the patch here. Making it simpler is easier said than done.
Attachment #8820539 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #5) > (In reply to Dão Gottwald [:dao] from comment #4) > > browser.shell.skipDefaultBrowserCheck is one of those confusing parts of > > this code. Apparently it's just there for keeping record of whether we're > > performing the first run. That's why it's already set to 'true' for all > > builds. > > So we could reuse it rather than adding another pref, no? We could just edit > the code so only the count stuff is behind the !BETA_OR_RELEASE check, and > then flip the default value for the pref to false on !BETA_OR_RELEASE, > flipping it to true on the funnelcake. That seems cleaner to me than adding > yet another pref here. It's not clear to me how you'd do that while preserving the current purpose of that pref. Maybe it's possible, my head still hurts a bit from looking at this code. In any case we should play it safe since we'll want to uplift. If it's possible to get rid of the new pref again, we can do that in a followup.
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/36ab9273387b Add pref to allow release builds to show the default browser prompt on second startup. r=jaws
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/36ab9273387b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Assignee | ||
Updated•7 years ago
|
Whiteboard: pref: browser.shell.skipDefaultBrowserCheckOnFirstRun = true
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8820539 [details] [diff] [review] patch Approval Request Comment [Feature/Bug causing the regression]: bug 1322718 comment 1 [User impact if declined]: standard release behavior in the funnelcake build [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: can't be verified in Nightly since the new behavior is disabled by default [Needs manual test from QE? If yes, steps to reproduce]: I assume QA will be part of the funnelcake process. This change will need to be part of that. [List of other uplifts needed for the feature/fix]: [Is the change risky?]: somewhat risky [Why is the change risky/not risky?]: the code is messy. Easy for QA to test though, given prepared builds. [String changes made/needed]:
Attachment #8820539 -
Flags: approval-mozilla-beta?
Attachment #8820539 -
Flags: approval-mozilla-aurora?
Updated•7 years ago
|
status-firefox51:
--- → affected
status-firefox52:
--- → affected
Comment 11•7 years ago
|
||
Comment on attachment 8820539 [details] [diff] [review] patch Onboarding funnelcake changes, OK for aurora and beta.
Attachment #8820539 -
Flags: approval-mozilla-beta?
Attachment #8820539 -
Flags: approval-mozilla-beta+
Attachment #8820539 -
Flags: approval-mozilla-aurora?
Attachment #8820539 -
Flags: approval-mozilla-aurora+
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/87a48d902eb2
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/aa6ce690f3d8
Comment 14•7 years ago
|
||
Setting the flag for verification, description available in Comment 0 and Comment 1.
Flags: qe-verify+
Flags: needinfo?(gwimberly)
Updated•7 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 15•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #4) > browser.shell.skipDefaultBrowserCheck is one of those confusing parts of > this code. Apparently it's just there for keeping record of whether we're > performing the first run. That's why it's already set to 'true' for all > builds. filed bug 1363118
You need to log in
before you can comment on or make changes to this bug.
Description
•