Closed
Bug 1322786
Opened 8 years ago
Closed 7 years ago
Crash in ThreadProfile::StreamJSON
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1340161
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: marcia, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Crash Data
This bug was filed from the Socorro interface and is report bp-e5ee03e4-0755-4ae8-b4fe-69c1c2161208. ============================================================= Seen while looking at Mac crash stats: http://bit.ly/2hdqgVr. Crashes started using 20161206030203 build. ni on :shu in case he has ideas about what might have caused the new crash.
Flags: needinfo?(shu)
Comment 1•7 years ago
|
||
Sorry, I don't know what's going on there. It looks like a nullptr dereference but the offset 0x6030 is very large. The crash itself seems to be in Maybe::emplace, in [1], but mUniqueStacks is definitely not +0x6030 in ThreadProfile. That would most likely point to sRegisteredThreads->at(i) being nullptr in [2]. I can't say why that would be, and why only on Mac. The code that manages sRegisteredThreads, IIRC, is [3]. This file hasn't been modified lately, and the latest changes to it don't look like threads were touched at all. [1] http://searchfox.org/mozilla-central/source/tools/profiler/core/ThreadProfile.cpp#51 [2] http://searchfox.org/mozilla-central/source/tools/profiler/core/GeckoSampler.cpp#564 [3] http://searchfox.org/mozilla-central/source/tools/profiler/core/platform-macos.cc
Flags: needinfo?(shu)
Comment 2•7 years ago
|
||
I can reproduce this some of the time with a thread filter of "GeckoMain,Compositor,_". I think something is going wrong with sRegisteredThreads when a thread shuts down.
Comment 3•7 years ago
|
||
This code has been rewritten extensively (e.g. ThreadProfile no longer exists), so this crash signature will no longer appear. And I fixed a similar crash in bug 1340161. So I think we can close this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•