1322801 - Create AccurateSeekingState and NextFrameSeekingState

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Tzuhao Kuo [:kaku]]

The preparation for bug 1322799 and bug 1322800.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 0 - correct build error;

Review commit: https://reviewboard.mozilla.org/r/98002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98002/

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 1 - create AccurateSeekingState and NextFrameSeekingState;

Review commit: https://reviewboard.mozilla.org/r/98004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98004/

Comment 3

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 2 - defer the creation of SeekTask into SeekingState's subclasses;

Review commit: https://reviewboard.mozilla.org/r/98006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98006/

Comment 4

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 3 - defer the logic of resetting MDSM to SeekingObject's subclasses;

Review commit: https://reviewboard.mozilla.org/r/98008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98008/

Comment 5

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 4 - defer the logic of invoking seek operation to SeekingObject's subclasses;

Review commit: https://reviewboard.mozilla.org/r/98010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98010/

Comment 6

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 5 - let AccurateSeekingState and NextFrameSeekingState have their own implementation of OnSeekTask{Resolved,Rejected}();

Review commit: https://reviewboard.mozilla.org/r/98012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98012/

Comment 7

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1322801 part 6 - defer the logic of CalculateNewCurrentTime to SeekingObject's subclasses;

Review commit: https://reviewboard.mozilla.org/r/98014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98014/

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817757 [details]
Bug 1322801 part 1 - create AccurateSeekingState and NextFrameSeekingState;

https://reviewboard.mozilla.org/r/98004/#review98460

::: dom/media/MediaDecoderStateMachine.cpp:1355
(Diff revision 1)
> +RefPtr<MediaDecoder::SeekPromise>
> +MediaDecoderStateMachine::
> +StateObject::SetSeekingState(SeekJob&& aSeekJob, EventVisibility aVisibility)
> +{
> +  if (aSeekJob.mTarget.IsAccurate() || aSeekJob.mTarget.IsFast()) {
> +    return SetState<AccurateSeekingState>(Forward<SeekJob>(aSeekJob), EventVisibility::Observable);

Move(aSeekJob)

::: dom/media/MediaDecoderStateMachine.cpp:1359
(Diff revision 1)
> +  if (aSeekJob.mTarget.IsAccurate() || aSeekJob.mTarget.IsFast()) {
> +    return SetState<AccurateSeekingState>(Forward<SeekJob>(aSeekJob), EventVisibility::Observable);
> +  }
> +
> +  if (aSeekJob.mTarget.IsNextFrame()) {
> +    return SetState<NextFrameSeekingState>(Forward<SeekJob>(aSeekJob), EventVisibility::Observable);

Ditto.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817756 [details]
Bug 1322801 part 0 - correct build error;

https://reviewboard.mozilla.org/r/98002/#review98462

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817758 [details]
Bug 1322801 part 2 - defer the creation of SeekTask into SeekingState's subclasses;

https://reviewboard.mozilla.org/r/98006/#review98466

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817760 [details]
Bug 1322801 part 4 - defer the logic of invoking seek operation to SeekingObject's subclasses;

https://reviewboard.mozilla.org/r/98010/#review98470

Comment 12

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817759 [details]
Bug 1322801 part 3 - defer the logic of resetting MDSM to SeekingObject's subclasses;

https://reviewboard.mozilla.org/r/98008/#review98468

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817761 [details]
Bug 1322801 part 5 - let AccurateSeekingState and NextFrameSeekingState have their own implementation of OnSeekTask{Resolved,Rejected}();

https://reviewboard.mozilla.org/r/98012/#review98472

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8817762 [details]
Bug 1322801 part 6 - defer the logic of CalculateNewCurrentTime to SeekingObject's subclasses;

https://reviewboard.mozilla.org/r/98014/#review98474

Comment 15

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817757 [details]
Bug 1322801 part 1 - create AccurateSeekingState and NextFrameSeekingState;

https://reviewboard.mozilla.org/r/98004/#review98460

> Move(aSeekJob)

And I did not pass the aVisibility to SetState<>()...

Comment 16

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817756 [details]
Bug 1322801 part 0 - correct build error;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98002/diff/1-2/

Comment 17

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817757 [details]
Bug 1322801 part 1 - create AccurateSeekingState and NextFrameSeekingState;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98004/diff/1-2/

Comment 18

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817758 [details]
Bug 1322801 part 2 - defer the creation of SeekTask into SeekingState's subclasses;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98006/diff/1-2/

Comment 19

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817759 [details]
Bug 1322801 part 3 - defer the logic of resetting MDSM to SeekingObject's subclasses;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98008/diff/1-2/

Comment 20

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817760 [details]
Bug 1322801 part 4 - defer the logic of invoking seek operation to SeekingObject's subclasses;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98010/diff/1-2/

Comment 21

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817761 [details]
Bug 1322801 part 5 - let AccurateSeekingState and NextFrameSeekingState have their own implementation of OnSeekTask{Resolved,Rejected}();

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98012/diff/1-2/

Comment 22

[Tzuhao Kuo [:kaku]]

Comment on attachment 8817762 [details]
Bug 1322801 part 6 - defer the logic of CalculateNewCurrentTime to SeekingObject's subclasses;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98014/diff/1-2/

Comment 23

[Tzuhao Kuo [:kaku]]

Try looks good. (Bug 1322799 comment 50)

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bc62f25e096
part 0 - correct build error; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/c472dabfb7ee
part 1 - create AccurateSeekingState and NextFrameSeekingState; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/2b067a79aa8c
part 2 - defer the creation of SeekTask into SeekingState's subclasses; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/6d1798f04e32
part 3 - defer the logic of resetting MDSM to SeekingObject's subclasses; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/232eee4da141
part 4 - defer the logic of invoking seek operation to SeekingObject's subclasses; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/4bbd6058ed53
part 5 - let AccurateSeekingState and NextFrameSeekingState have their own implementation of OnSeekTask{Resolved,Rejected}(); r=jwwang
https://hg.mozilla.org/integration/autoland/rev/0f7a82a599b2
part 6 - defer the logic of CalculateNewCurrentTime to SeekingObject's subclasses; r=jwwang

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3bc62f25e096
https://hg.mozilla.org/mozilla-central/rev/c472dabfb7ee
https://hg.mozilla.org/mozilla-central/rev/2b067a79aa8c
https://hg.mozilla.org/mozilla-central/rev/6d1798f04e32
https://hg.mozilla.org/mozilla-central/rev/232eee4da141
https://hg.mozilla.org/mozilla-central/rev/4bbd6058ed53
https://hg.mozilla.org/mozilla-central/rev/0f7a82a599b2