1322816 - Deal with giant textures

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now webrender doesn't seem to handle giant textures. These two reftests crash webrender:
  layout/reftests/bugs/632781-verybig.html
  layout/reftests/canvas/size-1.html

and I'm disabling them in bug 1319188. This bug is to re-enable them.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

For reference, running the 632781-verybig.html reftest produces this in the output:

REFTEST TEST-LOAD | file:///home/kats/zspace/mozilla-w2/layout/reftests/bugs/632781-verybig.html | 0 / 1 (0%)
thread '<unnamed>' panicked at 'assertion failed: allocation_size.width < max_texture_size()', /home/kats/zspace/mozilla-w2/gfx/webrender/src/texture_cache.rs:648

where the assertion that's failing is https://hg.mozilla.org/projects/graphics/file/73bdd29461ae/gfx/webrender/src/texture_cache.rs#l648

Comment 2

[Kartikaya Gupta (email:[e-mail])]

There are some crashtests that also run into this assertion:
  dom/canvas/crashtests/780392-1.html
  dom/canvas/crashtests/789933-1.html
  dom/media/test/crashtests/789075-1.html

I'll be disabling these soon in order to enable the crashtests on QR builds in automation.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The WR issue is closed, I'll retest these crashtests and see what happens.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79214a5ec7d951d7f2e561c080b9dd30b8209c5f

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Seems to be working, except for one failure. Still, fails-if is better than skip-if.

Final patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d704964dd009a1813e7699c980406707ff156fb

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1322816 - Re-enable some skipped reftests now that WebRender handles them.

Review commit: https://reviewboard.mozilla.org/r/122802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122802/

Comment 7

[Ryan Hunt [:rhunt] (on leave until early May)]

Comment on attachment 8850078 [details]
Bug 1322816 - Re-enable some skipped reftests now that WebRender handles them.

https://reviewboard.mozilla.org/r/122802/#review125022

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/62409ff101f1
Re-enable some skipped reftests now that WebRender handles them. r=rhunt

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/62409ff101f1