1322831 - Stopwatch.h won't compile with WINVER=0x0601

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: Remove dependence on Windows types from Stopwatch.h

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 8817808 [details] [diff] [review]
Remove dependence on Windows types from Stopwatch.h

Review of attachment 8817808 [details] [diff] [review]:
-----------------------------------------------------------------

Hm, okay. #including a Windows API file in our header files is probably undesirable and even if MS ever changes the size of the fields in the PROCESSOR_NUMBER struct, this patch doesn't change much for us (the current code also truncates, thanks to C++).

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #1)
> (the current code also truncates, thanks to C++).

Sorry this sounds confusing. I meant: the current code is fine, but it *would* truncate in the unlikely event the PROCESSOR_NUMBER struct is modified.

Comment 3

[Masatoshi Kimura [:emk]]

Try run just in case (it is very unlikely to be broken because WINVER is still 0x0501):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd1fa44a81dcc2011d399bb9973283309396bf84

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a01f2d3fd5a2
Remove dependence on Windows types from Stopwatch.h. r=jandem

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a01f2d3fd5a2