1322917 - Consolidate the padding of some dialogs/windows

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Some dialogs/windows have uncommon paddings.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: searchPadding.patch

This patch gives the same padding for the "Search Messages/Addresses" windows as for example the "Message Filters" dialog. I also fixed the "Mail Account Setup" dialog which had for example on Windows a padding of 28px. On Linux OS X it was 14px.

I've found now no more dialogs with obvious other paddings.

Comment 2

[:aceman]

Comment on attachment 8817904 [details] [diff] [review]
searchPadding.patch

Review of attachment 8817904 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/osx/mail/searchDialog.css
@@ -15,5 @@
>  @import url("chrome://messenger/skin/messageIcons.css");
>  
>  @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
>  
> -window {

Why changing element name to ID? I like the generics better, so it works regardless of ID. Or is this css file used in multiple dialog?

Comment 3

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #2)
> Comment on attachment 8817904 [details] [diff] [review]
> searchPadding.patch
> 
> Review of attachment 8817904 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/themes/osx/mail/searchDialog.css
> @@ -15,5 @@
> >  @import url("chrome://messenger/skin/messageIcons.css");
> >  
> >  @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
> >  
> > -window {
> 
> Why changing element name to ID? I like the generics better, so it works
> regardless of ID. Or is this css file used in multiple dialog?

It's not changing. It's removing unneeded element and adding the margins to direct childs. When I add the padding to window then also the splitter becomes the gap to the window border. This would be not visible now because the splitter is not visible except the grippy on OS X. But this could change in the future and need then a redefinition. With my proposal the selectors are the same on all platforms and then easier to maintain. On Windows the splitter is visible and on Linux it can be with some Linux themes.

Comment 4

[:aceman]

Comment on attachment 8817904 [details] [diff] [review]
searchPadding.patch

Review of attachment 8817904 [details] [diff] [review]:
-----------------------------------------------------------------

OK for the linux changes.

Comment 5

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/8c4fe399a2ebd1d046eac477af33745fa832f74d

Comment 6

[Jorg K (CEST = GMT+2)]

Sorry, I had to back that out an re-land it with the correct bug number:
https://hg.mozilla.org/comm-central/rev/248fec5fddc619fe451886d3778f74d7dab6ee07 - backout
https://hg.mozilla.org/comm-central/rev/e69ced0974d588e438569c22f71a0fcbf84c2b8e - re-land
With no bug number it will be very hard to associate the changeset with a bug later.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 8817904 [details] [diff] [review]
searchPadding.patch

[Approval Request Comment]
User impact if declined: some dialogs with too much padding
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Jorg K (CEST = GMT+2)]

Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/52c396f81ea475628720e7c296323b854f740c76