JavaScript strict warning: chrome://messenger/content/chat/imcontact.xml, line 160: SyntaxError: redefining delete is deprecated

RESOLVED FIXED in Thunderbird 55.0

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

unspecified
Thunderbird 55.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Looks like this has been upgraded to a JS error now, so it had to be fixed.
Attachment #8843779 - Flags: review?(clokep)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Note this breaks IM in current TB dailies if the user has more than zero contacts.
Comment on attachment 8843779 [details] [diff] [review]
Rename imContact.delete as redefining delete is now a JS error

Review of attachment 8843779 [details] [diff] [review]:
-----------------------------------------------------------------

Do we need a similar change for Instantbird, or is our code sufficiently different?
Attachment #8843779 - Flags: review?(clokep) → review+
(In reply to Patrick Cloke [:clokep] from comment #3)
> Do we need a similar change for Instantbird, or is our code sufficiently
> different?

It needs something similar, but I don't think it affects 52.
https://hg.mozilla.org/comm-central/rev/d03f6d1f69374c85d4939d0c7cb92021614600f4
Bug 1322929 - Rename imContact.delete as redefining delete is now a JS error. r=clokep
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in before you can comment on or make changes to this bug.