1322989 - When applying text-transform:uppercase to Greek, the accent on disjunctive eta (ή) should not be removed

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jonathan Kew [:jfkthame]]

This was mentioned in bug 307039 (see discussion at bug 307039 comment 65 and following), but never followed up.

One of the CSS Text testcases (text-transform-tailoring-005) covers this; see the URL field. Currently, we fail that test.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Preserve accent on Greek disjunctive eta (ή) when applying text-transform:uppercase

Assuming this is a behavior we want to support, here's a patch that fixes it so that we pass the related CSSWG testcase.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for uppercasing of Greek disjunctive eta (ή)

And a simple reftest that exercises this.

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/422af49b7ae8cb9218457535c8b0d3f4bec5f467
Bug 1322989 - Preserve accent on Greek disjunctive eta (ή) when applying text-transform:uppercase. r=m_kato

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9455be3e7f59f00bfc209aebc471073e23f20a7
Bug 1322989 - Reftest for uppercasing of Greek disjunctive eta (ή). r=m_kato

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23eb084202f6
Backed out changeset f9455be3e7f5 
https://hg.mozilla.org/integration/mozilla-inbound/rev/9034d9e08ee3
Backed out changeset 422af49b7ae8 for bustage

Comment 5

[Carsten Book [:Tomcat]]

backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=40811759&repo=mozilla-inbound

Comment 6

[Jonathan Kew [:jfkthame]]

Oops, sorry - I forgot we require those to be annotated these days. Will fix.

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d12ee8da73bc3448251d07b284a698a7b336842a
Bug 1322989 - Preserve accent on Greek disjunctive eta (ή) when applying text-transform:uppercase. r=m_kato

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d651df764664db0b6be181a7da57d8e5435e508
Bug 1322989 - Reftest for uppercasing of Greek disjunctive eta (ή). r=m_kato

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d12ee8da73bc
https://hg.mozilla.org/mozilla-central/rev/4d651df76466

Comment 9

[Chris Mills [:cmills]]

I've made sure that this requirement is successfully described on the text-transform ref page:
https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform

I've also added a note to the Fx53 release notes:
https://developer.mozilla.org/en-US/Firefox/Releases/53#CSS

Let me know if you think anything else is required for the docs. Thanks!