[Pointer Event] Update pointer event web-platform-tests

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM: Events
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: stone, Assigned: stone)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → sshih
(Assignee)

Comment 1

2 years ago
Created attachment 8818832 [details] [diff] [review]
Part1: Update pointerevent web-platform-tests

Updated tests cases from testing/web-platform/tests/pointerevents to dom/events/test/pointerevents/
Attachment #8818832 - Flags: review?(bugs)
(Assignee)

Comment 2

2 years ago
Created attachment 8818833 [details] [diff] [review]
Part2: PointerUp's buttons should be 0 when it's generated from touch
Attachment #8818833 - Flags: review?(bugs)

Comment 3

2 years ago
Comment on attachment 8818832 [details] [diff] [review]
Part1: Update pointerevent web-platform-tests

rs+
Attachment #8818832 - Flags: review?(bugs) → review+

Comment 4

2 years ago
Comment on attachment 8818833 [details] [diff] [review]
Part2: PointerUp's buttons should be 0 when it's generated from touch

oh, tiny bit odd to make changes to .cpp in a bug which is about wpt tests.
The spec is very vague about this case, but I think I can somehow interpret it this way too. Please test other browsers too.



(btw, don't we have bug handling pointermove.button)
Attachment #8818833 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

2 years ago
(In reply to Olli Pettay [:smaug] from comment #4)
> Comment on attachment 8818833 [details] [diff] [review]
> Part2: PointerUp's buttons should be 0 when it's generated from touch
> 
> oh, tiny bit odd to make changes to .cpp in a bug which is about wpt tests.
Oh, I forgot that I already created bug1323132 for this part. Sorry for that and I'll move part2 to bug1323132.
(Assignee)

Comment 6

2 years ago
Created attachment 8819116 [details] [diff] [review]
Bug 1322994: Update pointerevent web-platform-tests.

Updated the patch summary.
Attachment #8818832 - Attachment is obsolete: true
Attachment #8818833 - Attachment is obsolete: true
Attachment #8819116 - Flags: review+
(Assignee)

Updated

2 years ago
Blocks: 1323132
(Assignee)

Comment 7

2 years ago
(In reply to Olli Pettay [:smaug] from comment #4)
> Comment on attachment 8818833 [details] [diff] [review]
> Part2: PointerUp's buttons should be 0 when it's generated from touch
> 
> oh, tiny bit odd to make changes to .cpp in a bug which is about wpt tests.
> The spec is very vague about this case, but I think I can somehow interpret
> it this way too. Please test other browsers too.
Tested on canary 57.0.2950.0 and Edge 38.14393.0.0, both of them fire pointerup with button=0, buttons=0

> (btw, don't we have bug handling pointermove.button)
Yes if you mean the case of multiple buttons pressed and it's fixed in bug1292070
(Assignee)

Comment 8

2 years ago
Created attachment 8819205 [details] [diff] [review]
Bug 1322994: Update pointerevent web-platform-tests.
Attachment #8819116 - Attachment is obsolete: true
Attachment #8819205 - Flags: review+
(In reply to Ming-Chou Shih [:stone] from comment #7)
> > (btw, don't we have bug handling pointermove.button)
> Yes if you mean the case of multiple buttons pressed and it's fixed in
> bug1292070

I didn't mean multiple buttons but always setting button to WidgetMouseEvent::eLeftButton (== 0), but spec talking about -1.
(Assignee)

Comment 11

2 years ago
(In reply to Olli Pettay [:smaug] from comment #10)
> I didn't mean multiple buttons but always setting button to
> WidgetMouseEvent::eLeftButton (== 0), but spec talking about -1.
Oh, I totally misunderstand. That is a bug and created bug1323976 for it.

Comment 12

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df725ead108f
Update pointerevent web-platform-tests. r=smaug
Keywords: checkin-needed

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df725ead108f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.