Closed Bug 1323003 Opened 7 years ago Closed 7 years ago

JavascriptException: TypeError: arguments is not iterable: "let [pref_name, value, default_branch] = arguments;" in prefs.py

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: pi-marionette-firefox-puppeteer, regression)

Attachments

(1 file)

Bug 1323003 - Javascript arguments are not iterable in Firefox 45ESR.
58 bytes, text/x-review-board-request
impossibus
: review+
Details 
Since my patch on bug 1317270 landed, our tests don't work with Firefox 45 ESR builds anymore. It means that no updates could be tested for the upcoming 52 release. The failure as it can be seen is:

JavascriptException: TypeError: arguments is not iterable 
stacktrace:
	execute_script @prefs.py, line 173
	inline javascript, line 3
	src: "              let [pref_name, value, default_branch] = arguments;"

I will have to revert parts of this patch.
Attachment #8818013 - Flags: review?(mjzffr)
Comment on attachment 8818013 [details]
Bug 1323003 - Javascript arguments are not iterable in Firefox 45ESR.

https://reviewboard.mozilla.org/r/98160/#review98390
Attachment #8818013 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43e9784413f4
Javascript arguments are not iterable in Firefox 45ESR. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/43e9784413f4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Test-only change which need landing on aurora to fix a regression.
Assignee: nobody → hskupin
Whiteboard: [checkin-needed-aurora]
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.