JavascriptException: TypeError: arguments is not iterable: "let [pref_name, value, default_branch] = arguments;" in prefs.py

RESOLVED FIXED in Firefox 52

Status

Testing
Firefox UI Tests
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

({ateam-marionette-firefox-puppeteer, regression})

Version 3
mozilla53
ateam-marionette-firefox-puppeteer, regression
Points:
---

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Since my patch on bug 1317270 landed, our tests don't work with Firefox 45 ESR builds anymore. It means that no updates could be tested for the upcoming 52 release. The failure as it can be seen is:

JavascriptException: TypeError: arguments is not iterable 
stacktrace:
	execute_script @prefs.py, line 173
	inline javascript, line 3
	src: "              let [pref_name, value, default_branch] = arguments;"

I will have to revert parts of this patch.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8818013 - Flags: review?(mjzffr)

Comment 2

a year ago
mozreview-review
Comment on attachment 8818013 [details]
Bug 1323003 - Javascript arguments are not iterable in Firefox 45ESR.

https://reviewboard.mozilla.org/r/98160/#review98390
Attachment #8818013 - Flags: review?(mjzffr) → review+

Comment 3

a year ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43e9784413f4
Javascript arguments are not iterable in Firefox 45ESR. r=maja_zf

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/43e9784413f4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 5

a year ago
Test-only change which need landing on aurora to fix a regression.
Assignee: nobody → hskupin
Whiteboard: [checkin-needed-aurora]

Comment 6

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/450277eb1728
status-firefox52: affected → fixed
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.