1323003 - JavascriptException: TypeError: arguments is not iterable: "let [pref_name, value, default_branch] = arguments;" in prefs.py

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since my patch on bug 1317270 landed, our tests don't work with Firefox 45 ESR builds anymore. It means that no updates could be tested for the upcoming 52 release. The failure as it can be seen is:

JavascriptException: TypeError: arguments is not iterable 
stacktrace:
	execute_script @prefs.py, line 173
	inline javascript, line 3
	src: "              let [pref_name, value, default_branch] = arguments;"

I will have to revert parts of this patch.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1323003 - Javascript arguments are not iterable in Firefox 45ESR.

Review commit: https://reviewboard.mozilla.org/r/98160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98160/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8818013 [details]
Bug 1323003 - Javascript arguments are not iterable in Firefox 45ESR.

https://reviewboard.mozilla.org/r/98160/#review98390

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43e9784413f4
Javascript arguments are not iterable in Firefox 45ESR. r=maja_zf

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43e9784413f4

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Test-only change which need landing on aurora to fix a regression.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/450277eb1728