Intermittent dom/media/tests/mochitest/test_peerConnection_trackDisabling_clones.html | Test timed out.

RESOLVED FIXED in Firefox 53

Status

()

Core
WebRTC
P2
normal
Rank:
27
RESOLVED FIXED
a year ago
a month ago

People

(Reporter: Treeherder Bug Filer, Assigned: pehrsons)

Tracking

({intermittent-failure})

unspecified
mozilla53
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This is timing out when checking remote video for being black while disabled locally.

After disabling we only send one disabled frame. We might have to change that to send more, at a lower rate perhaps, since with packet loss the remote side might never receive the black frame, or with high load on the sender or with low bandwidth it might never get sent.
Rank: 35
Priority: -- → P3
Having disable get a black frame across is moderately important; bumping to low p2
Rank: 35 → 27
Priority: P3 → P2

Comment 3

a year ago
9 failures in 526 pushes (0.017 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 4
* autoland: 4
* mozilla-central: 1

Platform breakdown:
* windows7-32-vm: 6
* linux32: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1323079&startday=2016-12-12&endday=2016-12-18&tree=all

Comment 4

a year ago
9 failures in 609 pushes (0.015 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 7
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* linux64: 4
* windows7-32-vm: 2
* linux32: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1323079&startday=2016-12-19&endday=2016-12-25&tree=all
Assignee: nobody → pehrson
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8822195 [details]
Bug 1323079 - Send disabled frames no more often than 1 FPS over WebRTC.

https://reviewboard.mozilla.org/r/101174/#review102920

::: media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:199
(Diff revision 1)
>          return;
>        }
>  
> -      disabled_frame_sent_ = true;
> +      disabled_frame_sent_ = t;
>      } else {
> -      disabled_frame_sent_ = false;
> +      // This sets it to the null moment.

"to the Null time"
Attachment #8822195 - Flags: review?(rjesup) → review+
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d0fd553e1d0
Send disabled frames no more often than 1 FPS over WebRTC. r=jesup

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4d0fd553e1d0
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected

Comment 10

a month ago
1 failures in 792 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1323079&startday=2017-11-27&endday=2017-12-03&tree=all
You need to log in before you can comment on or make changes to this bug.