Closed Bug 1323098 Opened 3 years ago Closed 4 months ago

[meta] Chrome debugger protocol support for Firefox and Servo

Categories

(DevTools :: Debugger, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jimb, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: meta)

Firefox will be adopting the [Chrome debugging protocol][1] for internal use by selected devtool panels. This is the tracking bug for work related to Chrome protocol support for the JavaScript debugger.

[1]: https://developer.chrome.com/devtools/docs/debugger-protocol
We will be sharing some server code between Firefox and Servo.
Priority: -- → P3
Summary: Chrome debugger protocol support for Firefox and Servo → [meta] Chrome debugger protocol support for Firefox and Servo
Guessing this might fit better in Debugger, but feel free to revert!
Component: Developer Tools → Developer Tools: Debugger
That's great, thanks very much. (Originally I was going to handle both in one bug, and forgot to change the component when I changed my mind.)
Guys,

I want to dismiss alert in my WebExtension.
In Chrome, I can use chrome.debugger.sendCommand(tabId, "Page.handleJavaScriptDialog", params, function () {});

Since Firefox does not support chrome.debugger currently, is there an alternative, or workaround for that?
(In reply to Martin Zhai from comment #4)
> Guys,
Please see the Mozilla participation guidelines: https://www.mozilla.org/en-US/about/governance/policies/participation/
The Mozilla Project welcomes everyone, no matter how they identify themselves. However the word 'guys' is gendered and using it may result in making people uncomfortable.
Thanks for your understanding.

> I want to dismiss alert in my WebExtension.
> In Chrome, I can use chrome.debugger.sendCommand(tabId,
> "Page.handleJavaScriptDialog", params, function () {});
> 
> Since Firefox does not support chrome.debugger currently, is there an
> alternative, or workaround for that?
This isn't really related to this bug. You need a WebExtension API to be implemented in Firefox here, while this bug is about switching Firefox DevTools to the chrome protocol internally.
Luca, do you have a bug for implementing chrome.debugger in Firefox?
Flags: needinfo?(lgreco)
Hi Patrick, Hi Martin,
There are two bugs already filed related to the chrome.debugger API:

- Bug 1241448 - Support chrome.debugger
- Bug 1316741 - Implement chrome.debugger to let extensions use remote debugging protocol

The first issue was explicitly about "chrome parity" and it is currently closed as WONTFIX, mainly because at the time we didn't know that there were plans related to supporting the chrome protocol internally in the DevTools.

The second one is about being able to build an addon which connects itself to the debugging protocol and collect profiling data for analysis, possibly by presenting the same chrome.debugger API provided by Chrome.

Like already pointed out in the above issues, provide a "chrome-compatible" chrome.debugger API is something that is doable if that protocol is already supported at a Firefox DevTools level and we can wrap it into the chrome.debugger API (building one more "translation layer" between the "Chrome debugging protocol" and the "Firefox debugging protocol" and/or related Firefox internals inside the WebExtensions API implementation would not be a great solution in my own opinion).

Nevertheless, at least based on the scenario described in Comment 4:

Forcing an addon to require the "debugger" permission (which gives to the addon huge powers, basically on everything that is exposed to the debugging protocol) just to dismiss a javascript dialog in a selected tab seems a bit overkill
(it looks more like a workaround for an API that is currently missing in Chrome).

And so, in my opinion, it would better to open a bugzilla issue related to this specific API request ("an API to be able to dismiss a javascript dialog in a tab selected by tabId") so that we can discuss it in the next "WebExtensions APIs triage meeting" (https://wiki.mozilla.org/Add-ons/Contribute/Goodfirstbugs_triage#WebExtensions_APIs_Triage) separately from the bigger "Support/Implement chrome.debugger API" issues.
Flags: needinfo?(lgreco)
My apology for inappropriate words.

Luca's suggestion is very good. Though I have a consideration that, if provide another API to support handle javascript dialog, isn't it duplicate with some functionality in chrome.debugger?
Blocks: 1316741
Product: Firefox → DevTools
Priority: P3 → P5

closing as there are new bugs for cdp

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → INVALID

What are they, for people following along?

Flags: needinfo?(jlaster)
Flags: needinfo?(jlaster)
No longer blocks: 1316741
You need to log in before you can comment on or make changes to this bug.