RemoteVideoDecoder::DurationQueue access methods should be protected by a lock.

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
Audio/Video
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jolin, Assigned: jolin)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
std::dequeue is not guaranteed to be thread-safe and needs access protection.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → jolin

Comment 2

2 years ago
mozreview-review
Comment on attachment 8818208 [details]
Bug 1323152 - protect DurationQueue with lock.

https://reviewboard.mozilla.org/r/98350/#review98608
Attachment #8818208 - Flags: review?(snorp) → review+

Comment 3

2 years ago
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3500427ee76b
protect DurationQueue with lock. r=snorp

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3500427ee76b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.