Closed Bug 1323169 Opened 3 years ago Closed Last year

Fix test_about_pages to work with Fennec

Categories

(Testing :: Marionette, defect, P3)

Version 3
defect

Tracking

(firefox52 disabled, firefox53 disabled)

RESOLVED INVALID
Tracking Status
firefox52 --- disabled
firefox53 --- disabled

People

(Reporter: whimboo, Unassigned)

References

Details

(Whiteboard: [tests disabled][blocked by bug 1311041])

Attachments

(1 file)

As it can be seen for the following test job we have lots of failures in the unit test test_about_pages.py:

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=476845a2cafb42d02a5215fe63187c0638548edf&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=7829444

Failures:
* Unable to locate element: menu_newNavigatorTab
* No new tab has been opened (invalid shortcut key for Fennec)
* Unable to locate element: urlbar

With the above fixes we can make the 9th chunk green!
Depends on: 1323185
So some tests have to clearly be disabled because interacting with chrome is not possible on Android. For all the others which are opening a new tab due to Bug 1311041, I tried to change the way how we open the new tab and detect it. But sadly we miss Fennec support for getWindowHandles. I filed bug 1323185 for it.

So what we should do right now is simply skipping all the tests. I will have a patch up shortly.
Keywords: leave-open
Whiteboard: [tests disabled]
Comment on attachment 8818248 [details]
Bug 1323169 - Skip tests in test_about_pages.py for Fennec.

https://reviewboard.mozilla.org/r/98400/#review98730
Attachment #8818248 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e18bf6548df
Skip tests in test_about_pages.py for Fennec. r=maja_zf
Please uplift this test-only patch to aurora. Thanks.
Whiteboard: [tests disabled] → [tests disabled][checkin-needed-aurora]
needs rebasing for aurora

merging testing/marionette/harness/marionette/tests/unit/test_about_pages.py and testing/marionette/harness/marionette_harness/tests/unit/test_about_pages.py to testing/marionette/harness/marionette/tests/unit/test_about_pages.py
warning: conflicts while merging testing/marionette/harness/marionette/tests/unit/test_about_pages.py! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
Flags: needinfo?(hskupin)
Whiteboard: [tests disabled][checkin-needed-aurora] → [tests disabled]
Sorry, it needs bug 1320073 uplifted first. We will have to wait until this can happen.
Flags: needinfo?(hskupin)
Test-only (disable) patch we would like to have for the next ESR release. Please uplift to aurora. Thanks.
Whiteboard: [tests disabled] → [tests disabled][checkin-needed-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/fa49805cb82b
Whiteboard: [tests disabled][checkin-needed-aurora] → [tests disabled]
Assignee: hskupin → nobody
Status: ASSIGNED → NEW
Whiteboard: [tests disabled] → [tests disabled][blocked by bug 1311041]
With my patch on bug 1323185 we will be able to unskip the tests in this module for Fennec.
Priority: -- → P3
The leave-open keyword is there and there is no activity for 6 months.
:automatedtester, maybe it's time to close this bug?
Flags: needinfo?(dburns)
This specific test file doesn't exist anymore. Most of the test were moved into test_navigation.py, which mostly work for Fennec.
Status: NEW → RESOLVED
Closed: Last year
Flags: needinfo?(dburns)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.