1323186 - [Static Analysis][Result is Not Floating Point] In function ConstructBorderRenderer

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that the result of the following operations is not floating point:

>>  Float borderWidths[4] = { Float(border.top / twipsPerPixel),
>>                                   Float(border.right / twipsPerPixel),
>>                                   Float(border.bottom / twipsPerPixel),
>>                                   Float(border.left / twipsPerPixel) };

The correct approach is: 

>>  Float borderWidths[4] = { Float(border.top) / twipsPerPixel,
>>                                   Float(border.right) / twipsPerPixel,
>>                                   Float(border.bottom) / twipsPerPixel,
>>                                   Float(border.left) / twipsPerPixel };

Comment 1

[Andi [:andi]]

Attachment: Bug 1323186 - ensure the result of the operation is floating point.

Review commit: https://reviewboard.mozilla.org/r/98396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98396/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8818245 [details]
Bug 1323186 - ensure the result of the operation is floating point.

https://reviewboard.mozilla.org/r/98396/#review98686

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a1b2bb85201
ensure the result of the operation is floating point. r=mattwoodrow

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6a1b2bb85201