1323217 - ./mach marionette-test is broken since bug 1320073 landed

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

`./mach marionette-test` is broken:

% ./mach marionette-test testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py --gecko-log -
Error running mach:

    ['marionette-test', 'testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py', '--gecko-log', '-']

The error occurred in mach itself. This is likely a bug in mach itself or a
fundamental problem with a loaded module.

Please consider filing a bug against mach by going to the URL:

    https://bugzilla.mozilla.org/enter_bug.cgi?product=Core&component=mach


If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ImportError: No module named marionette.runtests

  File "/home/ato/src/gecko/python/mach/mach/main.py", line 352, in run
    return self._run(argv)
  File "/home/ato/src/gecko/python/mach/mach/main.py", line 407, in _run
    args = parser.parse_args(argv)
  File "/usr/lib/python2.7/argparse.py", line 1701, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1921, in _parse_known_args
    positionals_end_index = consume_positionals(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1898, in consume_positionals
    take_action(action, args)
  File "/usr/lib/python2.7/argparse.py", line 1807, in take_action
    action(self, namespace, argument_values, option_string)
  File "/home/ato/src/gecko/python/mach/mach/dispatcher.py", line 173, in __call__
    if handler.parser:
  File "/home/ato/src/gecko/python/mach/mach/decorators.py", line 77, in parser
    self._parser = self._parser()
  File "/home/ato/src/gecko/testing/marionette/mach_commands.py", line 27, in setup_marionette_argument_parser
    from marionette.runtests import MarionetteArguments
  File "/home/ato/src/gecko/build/mach_bootstrap.py", line 370, in __call__
module = self._original_import(name, globals, locals, fromlist, level)

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1323217 - Fix mach marionette-test;

testing/marionette/mach_commands.py contains wrong module imports.
The `marionette` Python package has been renamed to `marionette_harness`.

Review commit: https://reviewboard.mozilla.org/r/98422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98422/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8818305 [details]
Bug 1323217 - Fix mach marionette-test;

https://reviewboard.mozilla.org/r/98422/#review98626

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/489f981e8c2b
Fix mach marionette-test. r=whimboo a=test-only

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Regression from bug 1320073. We will have to get this uplifted to aurora too once the patch on the other bug gets uplifted.

Thanks for fixing it.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Test-only patch which we need on aurora. Please uplift the patch on bug 1320073 first within the same merge because this patch fixes a regression. Thanks.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Some deps haven't been landed on aurora yet and cause merge bustage. I will request those uplifts first.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b557465f8078