Closed Bug 1323254 Opened 3 years ago Closed 3 years ago

Update our in-tree ICU to 58.2

Categories

(Core :: JavaScript: Internationalization API, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(4 files)

Update to ICU 58.2 maintenance release.


From https://sourceforge.net/p/icu/mailman/message/35542934/:
---
Dear friends and users of ICU,

Today we are announcing the release of ICU 58.2, including updated data 
from CLDR 30.0.3 as well as and some major bug fixes which came in after 
the recent ICU 58.1 release in October. More details on the CLDR data 
updates, please see: 
http://cldr.unicode.org/index/downloads/cldr-30#TOC-CLDR-30.0.3-Maintenance-Release

The ICU 58.2 download links and release information are available at: 
http://site.icu-project.org/download/58

Note: After ICU 58.1 release, we changed the directory structure in the 
ICU SVN repository. If you're accessing ICU source files directly from the 
SVN repository, please read the note in this page: 
http://site.icu-project.org/repository

Best regards,
Yoshito Umaoka for the Unicode ICU Project
---



Diff 58.1 to 58.2:
http://bugs.icu-project.org/trac/changeset?old_path=%2Ftags%2Frelease-58-1%2Ficu4c&old=39541&new_path=%2Ftags%2Frelease-58-2%2Ficu4c&new=39541
ICU update created with:

  ./update-icu.sh https://ssl.icu-project.org/repos/icu/tags/release-58-2/icu4c/
Attachment #8818954 - Flags: review?(jwalden+bmo)
Update link to ICU svn repository.
Attachment #8818955 - Flags: review?(jwalden+bmo)
Comment on attachment 8818954 [details] [diff] [review]
bug1323254-part1.patch

Review of attachment 8818954 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure to regenerate this, in light of the update-*.sh changes I landed just today.  Not sure if that would change anything in these patches or not.
Attachment #8818954 - Flags: review?(jwalden+bmo) → review+
Attachment #8818955 - Flags: review?(jwalden+bmo) → review+
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #3)
> Make sure to regenerate this, in light of the update-*.sh changes I landed
> just today.  Not sure if that would change anything in these patches or not.

No changes were present when I regenerated the patch and compared it to the original patch.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/781f8641d2ef
Part 1: Update in-tree ICU to release 58.2. r=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/aef8ecf9b651
Part 2: Update url to ICU svn repository in update script. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/781f8641d2ef
https://hg.mozilla.org/mozilla-central/rev/aef8ecf9b651
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Should we consider taking this on Aurora52 as well as an update to the already-landed 58.1 there?
Flags: needinfo?(andrebargull)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> Should we consider taking this on Aurora52 as well as an update to the
> already-landed 58.1 there?

It probably makes sense to uplift to Aurora, but then we also need to uplift bug 1321030 and bug 1314920 (or alternatively merge these two tzdata updates into a single patch).

Waldo, does that sound good to you?
Flags: needinfo?(andrebargull) → needinfo?(jwalden+bmo)
(In reply to André Bargull from comment #8)
> It probably makes sense to uplift to Aurora, but then we also need to uplift
> bug 1321030 and bug 1314920 (or alternatively merge these two tzdata updates
> into a single patch).

Yeah, that sounds good.
Flags: needinfo?(jwalden+bmo)
Approval Request Comment
[Feature/Bug causing the regression]:
N/A

[User impact if declined]:
Wrong time zone data when calling methods from Intl.DateTimeFormat. And required to update to ICU 58.2.

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
This is a combined patch for bug 1314920 and bug 1321030. Both are required before we can update ICU 58.1 to ICU 58.2 (this bug).

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It only updates time zone data files, no code changes at all.

[String changes made/needed]:
None.
Attachment #8828529 - Flags: approval-mozilla-aurora?
Approval Request Comment
[Feature/Bug causing the regression]:
N/A

[User impact if declined]:
This is a minor update for ICU to fix some ICU methods and to update the internal CLDR data to CLDR 30.0.3. Release notes for ICU 58.2 are available at http://site.icu-project.org/download/58.

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
Already attached as "bug1323254-aurora-part1.patch (52)".

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
Mainly ICU CLDR data updates and ICU bug fixes. I'm not 100% sure, but I don't think we're currently using the fixed methods. At least I didn't see any direct calls to these methods when I searched for them on dxr.mozilla.org.

[String changes made/needed]:
N/A
Attachment #8828536 - Flags: approval-mozilla-aurora?
Comment on attachment 8828529 [details] [diff] [review]
bug1323254-aurora-part1.patch (52)

timezone data update for beta52
Attachment #8828529 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Comment on attachment 8828536 [details] [diff] [review]
bug1323254-aurora-part2.patch (52)

icu update for beta52

What could possibly go wrong.
Attachment #8828536 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Depends on: 1373763
No longer depends on: 1373763
You need to log in before you can comment on or make changes to this bug.