Closed Bug 1323276 Opened 3 years ago Closed 3 years ago

Fix and re-enable browser_newWindowDrop.js

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: dao, Assigned: arai)

References

Details

Attachments

(1 file)

browser_newWindowDrop.js is causing problems with the patches in bug 1322953 and bug 1323001. Somehow it pushes the search bar from the toolbar into the overflow panel, which breaks subsequent tests that interact with the search bar.

I'm going to disable this test.
Flags: needinfo?(arai.unmht)
Keywords: leave-open
thanks.

the testcase adds new-window-button button to toolbar.
it resets the toolbar state in cleanup function, but perhaps it's not working as expected.
https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/base/content/test/general/browser_newWindowDrop.js#23-29

will look into it.
apparently |CustomizableUI.reset();| doesn't do what I expected.
new-window-button is removed after the test, but everything except location bar is moved to overflow panel.
(In reply to Tooru Fujisawa [:arai] from comment #4)
> apparently |CustomizableUI.reset();| doesn't do what I expected.
> new-window-button is removed after the test, but everything except location
> bar is moved to overflow panel.

Somebody should probably look into this. Could you please file a new bug on it?
See Also: → 1323607
Changed CustomizableUI.reset to CustomizableUI.removeWidgetFromArea.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Flags: needinfo?(arai.unmht)
Attachment #8818736 - Flags: review?(dao+bmo)
Comment on attachment 8818736 [details] [diff] [review]
Use CustomizableUI.removeWidgetFromArea to explicitly remove new window button.

thanks!
Attachment #8818736 - Flags: review?(dao+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9062e2e53353b2d7c2e96201bc9b93a185233a01
Bug 1323276 - Use CustomizableUI.removeWidgetFromArea to explicitly remove new window button. r=dao
This can be marked FIXED now, right?
Flags: needinfo?(arai.unmht)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(arai.unmht)
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.