Port bug 1321593 - Refactor nsXREAppData so that -app and builtin share more codepaths, less manual memory management

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Trunk
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1321593 +++

Spinoff from bug 1306327 comment 7. Right now the normal Firefox startup path and the -app startup path are separate in annoying ways. Unifying those codepaths will make things better.
(Assignee)

Comment 1

2 years ago
Created attachment 8818359 [details] [diff] [review]
Port bug 1321593: Refactor nsXREAppData so that -app and builtin share more codepaths, less manual memory management

Try run coming up...
Attachment #8818359 - Flags: review?(philipp)
(Assignee)

Updated

2 years ago
Assignee: nobody → aleth
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
(In reply to aleth [:aleth] from comment #1)
> Try run coming up...
...when the blocking bug is on m-c.
(Assignee)

Updated

2 years ago
No longer blocks: 1306327
(Assignee)

Comment 3

2 years ago
Created attachment 8818364 [details] [diff] [review]
Port bug 1321593: Refactor nsXREAppData so that -app and builtin share more codepaths, less manual memory management

Something went wrong with the previous diff.
Attachment #8818364 - Flags: review?(philipp)
(Assignee)

Updated

2 years ago
Attachment #8818359 - Attachment is obsolete: true
Attachment #8818359 - Flags: review?(philipp)
(Assignee)

Comment 4

2 years ago
Local build seems fine, so I think we can do without a try push.
Comment on attachment 8818364 [details] [diff] [review]
Port bug 1321593: Refactor nsXREAppData so that -app and builtin share more codepaths, less manual memory management

Review of attachment 8818364 [details] [diff] [review]:
-----------------------------------------------------------------

yolo
Attachment #8818364 - Flags: review?(philipp) → review+

Comment 6

2 years ago
Comment on attachment 8818364 [details] [diff] [review]
Port bug 1321593: Refactor nsXREAppData so that -app and builtin share more codepaths, less manual memory management

Filename "." cannot be imported.
Attachment #8818364 - Attachment filename: . → 1323313.patch

Comment 7

2 years ago
https://hg.mozilla.org/comm-central/rev/1079f09bfccf085018d6d9b9a11f3f1aaccf2554
According to Richard this needed to land, so I pushed it.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.