1323326 - Refactor the normal loops over Timeouts inisde TimeoutManager to use ForEach helpers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

These generic loops need to run in the same way for both normal and
tracking timeouts.  This refactoring allows us to only change the
TimeoutManager ForEach helpers to loop over both linked lists when
splitting the timeouts into two separate lists without needing to
modify each call site separately.

Comment 1

[(no longer active)]

Attachment: Refactor the normal loops over Timeouts inisde TimeoutManager to use ForEach helpers

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8818385 [details] [diff] [review]
Refactor the normal loops over Timeouts inisde TimeoutManager to use ForEach helpers

Review of attachment 8818385 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/TimeoutManager.h
@@ +89,5 @@
>    {
> +    mTimeouts.ForEach(c);
> +  }
> +  template <class Callable>
> +  void ForEachTimeoutAbortable(Callable c)

Can you add a comment documenting that the Callable should return true to abort the loop?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d62ef0ed85e
Refactor the normal loops over Timeouts inisde TimeoutManager to use ForEach helpers; r=bkelly

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d62ef0ed85e