If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Welcome screen triggered at every private session visit

RESOLVED FIXED in Firefox 52

Status

()

Firefox for Android
Profile Handling
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: Ninu, Assigned: sebastian)

Tracking

({regression})

52 Branch
Firefox 53
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(fennec52+, firefox50 unaffected, firefox51 unaffected, firefox52 verified, firefox53 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
Environment: Nightly
Device: Sony Xperia X  (Android 6.0.1);
Build: Nightly 53.0a1 (2016-12-13);

Steps to reproduce:
1. Open Settings->Tools
2. Tap on New Guest Session button and confirm new session
3. Repeat steps above by going back to normal and re-visit private

Expected result:
NO Welcome screen should be present

Actual result:
Welcome screen is triggered at every private session visit

For further details please check https://www.youtube.com/watch?v=SIQPe8oYzns
(Reporter)

Updated

9 months ago
tracking-fennec: --- → ?
tracking-fennec: ? → 52+
Keywords: regression
Any chance you can get a regression range on this, Ninu?
Flags: needinfo?(mihai.ninu)
Version: Trunk → 52 Branch
(Reporter)

Comment 2

9 months ago
Hi Ryan,
The regression range(my bad) is between 12/10/2016(good) and 13/10/2016(bad) and the bug was triggered with the fix of Bug 1305984. 
All the best.
Flags: needinfo?(mihai.ninu)
Blocks: 1305984
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 3

9 months ago
I'll take this - Before bug 1305984 we showed the first run tour for restricted profiles - now we show the default first run tour - but we actually want to show none.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
Comment hidden (mozreview-request)

Comment 5

9 months ago
mozreview-review
Comment on attachment 8824041 [details]
Bug 1323408 - Do not show first run tour in guest profiles.

https://reviewboard.mozilla.org/r/102564/#review103178
Attachment #8824041 - Flags: review?(cnevinchen) → review+

Comment 6

8 months ago
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c57d40c4c50d
Do not show first run tour in guest profiles. r=nechen
(Assignee)

Comment 7

8 months ago
Comment on attachment 8824041 [details]
Bug 1323408 - Do not show first run tour in guest profiles.

Approval Request Comment

[Feature/Bug causing the regression]: The origin of the regression is unknown. Bug 1305984 fixed parts of the regression but this patch fixes it correctly.

[User impact if declined]: Without this patch we show the first run tour for new guest profiles. In theory that's not critical but we are advertising sync, which is not available in guest mode, and even link into sync settings (of the main profile).

[Is this code covered by automated tests?]: No, there are no automated tests for guest profiles. They are tricky.

[Has the fix been verified in Nightly?]: Not yet. Just landed the patch.

[Needs manual test from QE? If yes, steps to reproduce]: See comment 0.

[List of other uplifts needed for the feature/fix]: Even though bug 1305984 is related, the patch from the other bug is not needed. This patch here is enough to fix both issues.

[Is the change risky?]: No

[Why is the change risky/not risky?]: Because we only exit early from the first run tour check for guest profiles.

[String changes made/needed]: -
Attachment #8824041 - Flags: approval-mozilla-aurora?

Comment 8

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c57d40c4c50d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Mihai can you verify the fix in nightly?  Thanks!
Flags: needinfo?(mihai.ninu)
(Reporter)

Comment 10

8 months ago
Verified as fixed on the latest Nightly build 53.0a1 (2017-01-10) on Samsung Galaxy S6 EDGE with Android 6.0, a Nexus 9 with Android 6.0.1 and a Xiaomi mi i4 with Android 5.0.2.
status-firefox53: fixed → verified
Flags: needinfo?(mihai.ninu)
Comment on attachment 8824041 [details]
Bug 1323408 - Do not show first run tour in guest profiles.

don't show first run tour in guest mode, for aurora52
Attachment #8824041 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 12

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4244045e6f4d
status-firefox52: affected → fixed
(Reporter)

Comment 13

8 months ago
Verified as fixed on the latest Aurora build 52.0a2 (2017-01-18) on Samsung Galaxy S6 EDGE with Android 6.0.
(Reporter)

Updated

8 months ago
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.