1323408 - Welcome screen triggered at every private session visit

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[u549602]

Environment: Nightly
Device: Sony Xperia X  (Android 6.0.1);
Build: Nightly 53.0a1 (2016-12-13);

Steps to reproduce:
1. Open Settings->Tools
2. Tap on New Guest Session button and confirm new session
3. Repeat steps above by going back to normal and re-visit private

Expected result:
NO Welcome screen should be present

Actual result:
Welcome screen is triggered at every private session visit

For further details please check https://www.youtube.com/watch?v=SIQPe8oYzns

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Any chance you can get a regression range on this, Ninu?

Comment 2

[u549602]

Hi Ryan,
The regression range(my bad) is between 12/10/2016(good) and 13/10/2016(bad) and the bug was triggered with the fix of Bug 1305984. 
All the best.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

I'll take this - Before bug 1305984 we showed the first run tour for restricted profiles - now we show the default first run tour - but we actually want to show none.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1323408 - Do not show first run tour in guest profiles.

Review commit: https://reviewboard.mozilla.org/r/102564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102564/

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8824041 [details]
Bug 1323408 - Do not show first run tour in guest profiles.

https://reviewboard.mozilla.org/r/102564/#review103178

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c57d40c4c50d
Do not show first run tour in guest profiles. r=nechen

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8824041 [details]
Bug 1323408 - Do not show first run tour in guest profiles.

Approval Request Comment

[Feature/Bug causing the regression]: The origin of the regression is unknown. Bug 1305984 fixed parts of the regression but this patch fixes it correctly.

[User impact if declined]: Without this patch we show the first run tour for new guest profiles. In theory that's not critical but we are advertising sync, which is not available in guest mode, and even link into sync settings (of the main profile).

[Is this code covered by automated tests?]: No, there are no automated tests for guest profiles. They are tricky.

[Has the fix been verified in Nightly?]: Not yet. Just landed the patch.

[Needs manual test from QE? If yes, steps to reproduce]: See comment 0.

[List of other uplifts needed for the feature/fix]: Even though bug 1305984 is related, the patch from the other bug is not needed. This patch here is enough to fix both issues.

[Is the change risky?]: No

[Why is the change risky/not risky?]: Because we only exit early from the first run tour check for guest profiles.

[String changes made/needed]: -

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c57d40c4c50d

Comment 9

[Julien Cristau [:jcristau]]

Mihai can you verify the fix in nightly?  Thanks!

Comment 10

[u549602]

Verified as fixed on the latest Nightly build 53.0a1 (2017-01-10) on Samsung Galaxy S6 EDGE with Android 6.0, a Nexus 9 with Android 6.0.1 and a Xiaomi mi i4 with Android 5.0.2.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8824041 [details]
Bug 1323408 - Do not show first run tour in guest profiles.

don't show first run tour in guest mode, for aurora52

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4244045e6f4d

Comment 13

[u549602]

Verified as fixed on the latest Aurora build 52.0a2 (2017-01-18) on Samsung Galaxy S6 EDGE with Android 6.0.