1323451 - Fix test failures for Fennec in test_navigation.py

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Treeherder Bug Filer]

Filed by: hskupin [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=7891936&repo=autoland

https://queue.taskcluster.net/v1/task/JIz81TewS_622sxXZCBq5w/runs/0/artifacts/public/logs/live_backing.log

The following failures are currently present for tests run against Fennec:

* TEST-UNEXPECTED-ERROR | test_navigation.py TestNavigate.test_about_blank_for_new_docshell | NoSuchWindowException: No such content frame; perhaps the listener was not registered?

* TEST-UNEXPECTED-ERROR | test_navigation.py TestNavigate.test_invalid_protocol | IOError: Process has been unexpectedly closed (Exit code: 0) (Reason: Connection timed out after 60.0s)

* TEST-UNEXPECTED-FAIL | test_navigation.py TestNavigate.test_navigate_chrome_error | AssertionError: MarionetteException not raised

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1323451 - Fix test failures in test_navigation.py for Fennec.

Review commit: https://reviewboard.mozilla.org/r/98852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98852/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8818923 [details]
Bug 1323451 - Fix test failures in test_navigation.py for Fennec.

https://reviewboard.mozilla.org/r/98852/#review99114

::: testing/marionette/driver.js:1017
(Diff revision 1)
>      case Context.CHROME:
> -      // At least on desktop, navigating in chrome scope does not
> +      // At least on desktop and Android, navigating in chrome scope does not
>        // correspond to something a user can do, and leaves marionette
>        // and the browser in an unusable state. Return a generic error insted.
>        // TODO: Error codes need to be refined as a part of bug 1100545 and
>        // bug 945729.
> -      if (this.appName == "Firefox") {
> +      if (this.appName == "Firefox" || this.appName == "Fennec") {
>          throw new UnknownError("Cannot navigate in chrome context");
>        }
>  
>        this.getCurrentWindow().location.href = url;
>        yield this.pageLoadPromise();
>        break;

I guess it was possible to navigate the chrome scope on B2G.  Since we don’t support that anymore, I suggest we remove this altogether and return an `UnsupportedOperationError`.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8818923 [details]
Bug 1323451 - Fix test failures in test_navigation.py for Fennec.

https://reviewboard.mozilla.org/r/98852/#review99114

> I guess it was possible to navigate the chrome scope on B2G.  Since we don’t support that anymore, I suggest we remove this altogether and return an `UnsupportedOperationError`.

I tried to make this change as minimal as possible. But maybe it's indeed the better option to do right now.

Another option would that we kill the switch between content and chrome, and always run the get() in the content space. Wouldn't that make more sense?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8818923 [details]
Bug 1323451 - Fix test failures in test_navigation.py for Fennec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98852/diff/1-2/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8818923 [details]
Bug 1323451 - Fix test failures in test_navigation.py for Fennec.

https://reviewboard.mozilla.org/r/98850/#review99134

I pushed an update with your proposed changes. Please let me know if that is fine. Thanks.

Comment 6

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Comment on attachment 8818923 [details]
> Bug 1323451 - Fix test failures in test_navigation.py for Fennec.
> 
> https://reviewboard.mozilla.org/r/98850/#review99134
> 
> I pushed an update with your proposed changes. Please let me know if that is
> fine. Thanks.

r+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b52c0a02c07b
Fix test failures in test_navigation.py for Fennec. r=ato

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b52c0a02c07b

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Test-only change which we would like to see for the 52.0 release. So please uplift to aurora. Thanks.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b494291dfc82

Comment 11

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.