1323521 - Prevent Windows 10 touchscreens from launching a11y

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I think that I have cracked this nut...

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1323521: Prevent Windows touchscreen support from instantiating a11y;

Review commit: https://reviewboard.mozilla.org/r/98632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98632/

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8818621 [details]
Bug 1323521: Prevent Windows touchscreen support from instantiating a11y;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98632/diff/1-2/

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8818621 [details]
Bug 1323521: Prevent Windows touchscreen support from instantiating a11y;

https://reviewboard.mozilla.org/r/98632/#review98938

Looks good, lets land on nightly and see how it goes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47b072202511
Prevent Windows touchscreen support from instantiating a11y; r=jimm

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

I'll re-push on inbound with a fixed patch that doesn't f up line endings.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e00689493b6e712340f902ccd5480b99815ccf9
Bug 1323521: Prevent Windows touchscreen support from instantiating a11y; r=jimm

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e00689493b6

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

This is great, Aaron should we (you) request uplift or would you like to try to solve the Windows 8 case first?

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

We can do this independently of the Windows 8 problem.

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8818621 [details]
Bug 1323521: Prevent Windows touchscreen support from instantiating a11y;

Approval Request Comment
[Feature/Bug causing the regression]: Windows 10 touchscreens on e10s
[User impact if declined]: No touch support for Windows 10 on 52.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Really simple patch.
[String changes made/needed]: None

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8818621 [details]
Bug 1323521: Prevent Windows touchscreen support from instantiating a11y;

Sounds good, we want to support the touchscreen without incorrectly poking the a11y API.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3e93be52e058

Comment 13

[u554753]

Per Comment 10, it was noted there are no steps to reproduce to be able to verify. Yet a flag is saying to do such.

Aaron, are there any preferences we would need to set or any way to see in about:support whether or not we know a11y is working [or prevented in this case] as intended? Or do we just go over the touch screen functionality and ensure that's working at all? Thanks.

Comment 14

[(No longer employed by Mozilla) Aaron Klotz]

Probably the best thing to do is to go through the touch screen functionality, make sure it is working, as you said. But then after doing all of that touchscreen stuff, go to about:support and check the Accessibility section. "Activated" should be false.

Comment 15

[u554753]

Working as intended with the following user agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0