1323522 - Remove all XP code from nrappkit and nICEr

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P3)

Comment 1

[Nils Ohlmeier [:drno]]

Code to remove would be inet_ntop() and inet_pton() from nrappkit here (assuming bug 1322546 removes already the snprintf() implementation) https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/media/mtransport/third_party/nrappkit/src/util/util.h#69

And the '#if (_WIN32_WINNT >= 0x0600)' here: https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/media/mtransport/third_party/nICEr/src/stun/addrs.c#229

Comment 2

[Masatoshi Kimura [:emk]]

The VS2015 snprintf() implementation will also work WinXP. It does not have to do with xp-eol.

Comment 3

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this still relevant?

Comment 5

[Byron Campen [:bwc]]

Yeah, it looks like we could still remove this stuff.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Interested in taking this, emk? :-)

Comment 7

[Masatoshi Kimura [:emk]]

Yes :)
The latest permalink for the record (Searchfox dislikes rev 8103c612b79c2587ea4ca1b0a9f9f82db4b185b8 for some reason):
https://searchfox.org/mozilla-central/rev/bf272a7be6fef0e91bde01dfe1f68403d8fbc237/dom/media/webrtc/transport/third_party/nrappkit/src/util/util.h#68
https://searchfox.org/mozilla-central/rev/bf272a7be6fef0e91bde01dfe1f68403d8fbc237/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-win32.c#184

Comment 8

[Masatoshi Kimura [:emk]]

Attachment: Bug 1323522 - Remove all XP code from nrappkit and nICEr. r?#webrtc-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c2784b5960d
Remove all XP code from nrappkit and nICEr. r=webrtc-reviewers,ng

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2c2784b5960d