Closed Bug 1323531 Opened 8 years ago Closed 7 years ago

internal compiler error while compiling with --ccov

Categories

(Testing :: Code Coverage, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Unassigned)

Details

[task 2016-12-07T23:34:29.975693Z] 23:34:29     INFO -  /home/worker/workspace/build/src/js/src/wasm/WasmBaselineCompile.cpp: In member function 'bool js::wasm::BaseCompiler::emitStore(js::wasm::ValType, js::Scalar::Type)':
[task 2016-12-07T23:34:29.976237Z] 23:34:29     INFO -  /home/worker/workspace/build/src/js/src/wasm/WasmBaselineCompile.cpp:6399:1: internal compiler error: in assign_by_spills, at lra-assigns.c:1281
[task 2016-12-07T23:34:29.976299Z] 23:34:29     INFO -   }
[task 2016-12-07T23:34:29.976805Z] 23:34:29     INFO -   ^
[task 2016-12-07T23:34:29.976865Z] 23:34:29     INFO -  0x7edc4f assign_by_spills
[task 2016-12-07T23:34:29.977303Z] 23:34:29     INFO -  	../../gcc-4.8.5/gcc/lra-assigns.c:1281
[task 2016-12-07T23:34:29.977383Z] 23:34:29     INFO -  0x7edc4f lra_assign()
[task 2016-12-07T23:34:29.977840Z] 23:34:29     INFO -  	../../gcc-4.8.5/gcc/lra-assigns.c:1438
[task 2016-12-07T23:34:29.977921Z] 23:34:29     INFO -  0x7e99a9 lra(_IO_FILE*)
[task 2016-12-07T23:34:29.978362Z] 23:34:29     INFO -  	../../gcc-4.8.5/gcc/lra.c:2310
[task 2016-12-07T23:34:29.978439Z] 23:34:29     INFO -  0x7b5ca8 do_reload
[task 2016-12-07T23:34:29.978841Z] 23:34:29     INFO -  	../../gcc-4.8.5/gcc/ira.c:4670
[task 2016-12-07T23:34:29.979271Z] 23:34:29     INFO -  0x7b5ca8 rest_of_handle_reload
[task 2016-12-07T23:34:29.979331Z] 23:34:29     INFO -  	../../gcc-4.8.5/gcc/ira.c:4794
[task 2016-12-07T23:34:29.979468Z] 23:34:29     INFO -  Please submit a full bug report,
[task 2016-12-07T23:34:29.979529Z] 23:34:29     INFO -  with preprocessed source if appropriate.
[task 2016-12-07T23:34:29.979964Z] 23:34:29     INFO -  Please include the complete backtrace with any bug report.
[task 2016-12-07T23:34:29.980040Z] 23:34:29     INFO -  See <http://gcc.gnu.org/bugs.html> for instructions.
[task 2016-12-07T23:34:29.980404Z] 23:34:29     INFO -  gmake[5]: *** [Unified_cpp_js_src37.o] Error 1
[task 2016-12-07T23:34:29.980471Z] 23:34:29     INFO -  gmake[5]: *** Waiting for unfinished jobs....
[task 2016-12-07T23:34:33.610730Z] 23:34:33     INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/js/src/Unified_cpp_js_src28.cpp:47:0:


from this log:
https://public-artifacts.taskcluster.net/coJX2y3qR7OkF97Jbt4Oxg/0/public/logs/live_backing.log
as a note, this is linux64 opt where this happens- it seems to have occurred sometime in early November.  I heard we were looking to upgrade to gcc 4.9.  I am not sure how to do that, Nathan, do you have any patches or guidance on testing this with gcc 4.9 ?
Flags: needinfo?(nfroyd)
(In reply to Joel Maher ( :jmaher) from comment #1)
> as a note, this is linux64 opt where this happens- it seems to have occurred
> sometime in early November.  I heard we were looking to upgrade to gcc 4.9. 
> I am not sure how to do that, Nathan, do you have any patches or guidance on
> testing this with gcc 4.9 ?

According to bug 1029245 comment 13, glandium has stuck GCC 4.9 tarballs in tooltool; you might try using those in --ccov builds and see if that helps any.
Flags: needinfo?(nfroyd)
oh, this is fixed with gcc 4.9:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=689e43dc40dd556aee85c44964417c11d8ad43da

now how to get 4.9 as the default standard?  in bug 1029245 it is unclear if there is a real motivation to use a newer gcc.  Although upgrading would probably fix a frequent intermittent in bug 1308685.

In the meantime, possibly we can move forward with finding a way to use gcc 4.9 in the code coverage build configs?
(In reply to Joel Maher ( :jmaher) from comment #3)
> oh, this is fixed with gcc 4.9:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=689e43dc40dd556aee85c44964417c11d8ad43da
> 
> now how to get 4.9 as the default standard?  in bug 1029245 it is unclear if
> there is a real motivation to use a newer gcc.  Although upgrading would
> probably fix a frequent intermittent in bug 1308685.

I am planning on switching both automation builds and the required default to 4.9 Real Soon Now.

> In the meantime, possibly we can move forward with finding a way to use gcc
> 4.9 in the code coverage build configs?

This change should just require using a different tooltool manifest, right?
yes, it is very easy fix:
https://hg.mozilla.org/try/rev/689e43dc40dd556aee85c44964417c11d8ad43da

I am not sure if that can be done only when building code coverage- if Real Soon Now translates to sometime in the next couple of weeks (i.e. 2016), then I we can just wait, do reply to this bug if it looks as though it is more of a 2017 action item.

Nathan, thanks for upgrading GCC to 4.9 or something newer.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.