Implement TakeElementScreenshot command

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: whimboo, Unassigned)

Tracking

(Blocks 1 bug)

Version 3
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

The webdriver spec says that we should have a TakeElementScreenshot command, which hasn't been implemented yet.

https://w3c.github.io/webdriver/webdriver-spec.html#take-element-screenshot

The code as necessary to run already exists in the current screenshot command but would have to be untangled into this new method.

We should keep backward compatibility for now so screenshot should forward element screenshots to the new method.

We should wait until bug 1243415 has been landed.
Can't the Chrome code use the current capture code for element screenshots?
Flags: needinfo?(hskupin)
I thought we need a 1-1 mapping for each command in Marionette. Isn't it the case? When I talked with Andreas he agreed on it. So please figure both out.
Flags: needinfo?(hskupin) → needinfo?(ato)
I don’t care particularly if we call GeckoDriver.prototype.takeScreenshot with {full: false} from geckodriver.  This means we can avoid adding a new command to Marionette.
Flags: needinfo?(ato)
This feels like a bug that should be filed in geckodriver.
This was added in https://github.com/mozilla/webdriver-rust/commit/bce83b87fc082fba52c4857a57296f141e27b53c and https://github.com/mozilla/geckodriver/commit/cb67c0aa66e3d50223de8e79eb4e1333bfb09401

As long as we have the necessary endpoints, how we implement it internally doesn't matter.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.