1323645 - Frequently timed out on Android 4.3 debug: dom/tests/mochitest/webcomponents/test_custom_element_htmlconstructor.html | Test timed out.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Edgar Chen [:edgar]]

test_custom_element_htmlconstructor.html is added in bug 1274159. And it frequently timed out on Android 4.3 debug [1][2], so we disable it on android first and file this bug to follow up.

Android tests are running on emulator which is quite slow, we probably need to split this test into smaller pieces. 

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=86d70a2e93e1c1fa3b500e3ab648d1e61db7a438

Comment 1

[Edgar Chen [:edgar]]

Or reuse the test iframe as much as possible, instead of creating a new iframe for each test.

Comment 2

[Adam Vandolder [:avandolder]]

Attachment: Bug 1323645 - Enable custom element HTMLConstructor chrome test for Android. r?edgar

Comment 3

[Adam Vandolder [:avandolder]]

This test was actually enabled some time ago as part of the fix to Bug 1585119. The equivalent chrome test, though, was left turned off. Since the chrome mochitests aren't tested on Android, removing this flag should not cause any further timeouts. I've push a try run of the Android mochitests as well: https://treeherder.mozilla.org/jobs?repo=try&revision=71ca2d203014364cba93501ef4d7e363d7bad3c

Comment 4

[Edgar Chen [:edgar]]

(In reply to Adam Vandolder [:avandolder] from comment #3)

This test was actually enabled some time ago as part of the fix to Bug 1585119. The equivalent chrome test, though, was left turned off. Since the chrome mochitests aren't tested on Android

Ah, right, mochitest-chrome aren't run on Android currently, https://searchfox.org/mozilla-central/rev/4a15041348e08fb0d6f5726015c32861e663fbfe/taskcluster/ci/test/test-sets.yml#373-458. Geoffrey, do you know why mochitest-chrome test aren't run on Android? Thanks!

Comment 5

[Geoff Brown [:gbrown]]

I'm not sure I do remember; my vague memories are:

• most mochitest-chrome tests have always failed on android, because they make assumptions about Firefox chrome
• a limited set of mochitest-chrome tests were written for android and ran for a while on the 4.3 emulator
• around the time we moved to the 7.0 x86_64 emulator, we started running geckoview-junit tests, and some of those junit tests provided similar coverage to the existing android mochitest-chrome tests; the geckoview team didn't want to port the remaining tests to the new environment, so we stopped running the suite altogether.

Comment 6

[Adam Vandolder [:avandolder]]

It should be safe for me to go ahead and land this then?

Comment 7

[Edgar Chen [:edgar]]

Yes, just go ahead and land this. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56fe83ffe23e
Enable custom element HTMLConstructor chrome test for Android. r=edgar

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/56fe83ffe23e