Closed Bug 1323651 Opened 3 years ago Closed 3 years ago

Rename functions / properties names with GroupedSessionHistory / PartialSessionHistory to GroupedSHistory / PartialSHistory

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: freesamael, Assigned: freesamael)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

I was willing to make more clear naming when writing nsIGroupedSHistory / nsIPartialSHistory, so I did appendPartialSessionHistory and other similar names, but now I think it's just too verbose and we're using incoherent names in different places which is a bit annoying. 

Let's just make it all be GroupedSHistory or PartialSHistory.
Priority: -- → P3
MozReview-Commit-ID: G2GW4ZPIfH3
Comment on attachment 8819803 [details] [diff] [review]
Rename Partial/GroupedSessionHistory to Partial/GroupedSHistory

Hi Ehsan,

It's a simple renaming patch to make our life a bit easier. Would you take a look?
Attachment #8819803 - Attachment description: Rename Partial/GroupedSessionHistory to Partial/GroupedSHistory. r=ehsan → Rename Partial/GroupedSessionHistory to Partial/GroupedSHistory
Attachment #8819803 - Flags: review?(ehsan)
Assignee: nobody → sawang
Attachment #8819803 - Flags: review?(ehsan) → review+
Attachment #8819803 - Attachment is obsolete: true
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/664f73663acb
Rename Partial/GroupedSessionHistory to Partial/GroupedSHistory. r=ehsan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/664f73663acb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.