Closed Bug 1323652 Opened 7 years ago Closed 7 years ago

stylo: several tests panic with "got unknown property name from Gecko: ()"

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: heycam, Assigned: xidorn)

References

Details

thread '<unnamed>' panicked at 'got unknown property name from Gecko: ()', ../src/libcore/result.rs:799
stack backtrace:
   1:     0x7fffea9ba11f - std::sys::backtrace::tracing::imp::write::hd6ece0fd16ebfe06
   2:     0x7fffea9c967d - std::panicking::default_hook::{{closure}}::h523f1cb7f97bbc83
   3:     0x7fffea9c6bda - std::panicking::default_hook::hc3c81c24cdcc8c31
   4:     0x7fffea9c71d8 - std::panicking::rust_panic_with_hook::hf4b937f570e0ba05
   5:     0x7fffea9c7032 - std::panicking::begin_panic::h4a0c5d0b7e602ca9
   6:     0x7fffea9c6fb0 - std::panicking::begin_panic_fmt::h76753862db1b73c1
   7:     0x7fffea9c6f31 - rust_begin_unwind
   8:     0x7fffea9d92af - core::panicking::panic_fmt::h01b74bf8a81c45ca
   9:     0x7fffe9d7d93e - core::result::unwrap_failed::ha1afe20e3ec72757
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libcore/macros.rs:29
  10:     0x7fffe9d5e991 - <core::result::Result<T, E>>::expect::h40016a88d12b0800
                        at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libcore/result.rs:761
  11:     0x7fffe9eac345 - geckoservo::glue::get_property_id_from_atom::h877504ef90fb562e
                        at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:655
  12:     0x7fffe9eac5d0 - Servo_DeclarationBlock_SetProperty
                        at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:682
  13:     0x7fffe6db4feb - _ZN19nsDOMCSSDeclaration18ParsePropertyValueE15nsCSSPropertyIDRK18nsAString_internalb
                        at /z/stylo/hg-incubator/layout/style/nsDOMCSSDeclaration.cpp:310
  14:     0x7fffe6db4b32 - _ZN19nsDOMCSSDeclaration16SetPropertyValueE15nsCSSPropertyIDRK18nsAString_internal
                        at /z/stylo/hg-incubator/layout/style/nsDOMCSSDeclaration.cpp:92
  15:     0x7fffe6db49f0 - _ZN28nsDOMCSSAttributeDeclaration16SetPropertyValueE15nsCSSPropertyIDRK18nsAString_internal
                        at /z/stylo/hg-incubator/layout/style/nsDOMCSSAttrDeclaration.cpp:203
  16:     0x7fffe4be8761 - _ZN19nsDOMCSSDeclaration19SetCounterIncrementERK18nsAString_internalRN7mozilla11ErrorResultE
                        at /z/stylo/hg-incubator/layout/style/nsCSSPropList.h:1598
  17:     0x7fffe4b33020 - _ZN7mozilla3dom21CSS2PropertiesBindingL20set_counterIncrementEP9JSContextN2JS6HandleIP8JSObjectEEP19nsDOMCSSDeclaration19JSJitSetterCallArgs
                        at /z/stylo/hg-incubator/obj/dom/bindings/CSS2PropertiesBinding.cpp:14531
  18:     0x7fffe58aa3d7 - _ZN7mozilla3dom20GenericBindingSetterEP9JSContextjPN2JS5ValueE
                        at /z/stylo/hg-incubator/dom/bindings/BindingUtils.cpp:2854
  19:     0x7fffe96a761c - _ZN2js12CallJSNativeEP9JSContextPFbS1_jPN2JS5ValueEERKNS2_8CallArgsE
                        at /z/stylo/hg-incubator/js/src/jscntxtinlines.h:239
  20:     0x7fffe968b46f - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:457
  21:     0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502
  22:     0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521
  23:     0x7fffe968c47a - _ZN2js10CallSetterEP9JSContextN2JS6HandleINS2_5ValueEEES5_S5_
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:648
  24:     0x7fffe96eabe7 - _ZL19SetExistingPropertyP9JSContextN2JS6HandleIPN2js12NativeObjectEEENS2_I4jsidEENS2_INS1_5ValueEEESA_S6_NS2_IPNS3_5ShapeEEERNS1_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/vm/NativeObject.cpp:2437
  25:     0x7fffe96ea211 - _ZN2js17NativeSetPropertyEP9JSContextN2JS6HandleIPNS_12NativeObjectEEENS3_I4jsidEENS3_INS2_5ValueEEESA_NS_13QualifiedBoolERNS2_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/vm/NativeObject.cpp:2472
  26:     0x7fffe8dc19ae - _ZN2js11SetPropertyEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS3_INS2_5ValueEEESA_RNS2_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/vm/NativeObject.h:1540
  27:     0x7fffe9505d1c - _ZN2js30SetPropertyIgnoringNamedGetterEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS3_INS2_5ValueEEESA_NS3_INS2_18PropertyDescriptorEEERNS2_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/proxy/BaseProxyHandler.cpp:182
  28:     0x7fffe58ae788 - _ZNK7mozilla3dom15DOMProxyHandler3setEP9JSContextN2JS6HandleIP8JSObjectEENS5_I4jsidEENS5_INS4_5ValueEEESC_RNS4_14ObjectOpResultE
                        at /z/stylo/hg-incubator/dom/bindings/DOMJSProxyHandler.cpp:258
  29:     0x7fffe950db84 - _ZN2js5Proxy3setEP9JSContextN2JS6HandleIP8JSObjectEENS4_I4jsidEENS4_INS3_5ValueEEESB_RNS3_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/proxy/Proxy.cpp:333
  30:     0x7fffe950f37c - _ZN2js17proxy_SetPropertyEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS3_INS2_5ValueEEESA_RNS2_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/proxy/Proxy.cpp:589
  31:     0x7fffe9461f2c - _ZN8JSObject20nonNativeSetPropertyEP9JSContextN2JS6HandleIPS_EENS3_I4jsidEENS3_INS2_5ValueEEES9_RNS2_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/jsobj.cpp:1019
  32:     0x7fffe8dc194d - _ZN2js11SetPropertyEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS3_INS2_5ValueEEESA_RNS2_14ObjectOpResultE
                        at /z/stylo/hg-incubator/js/src/vm/NativeObject.h:1539
  33:     0x7fffe969b30f - _ZL20SetPropertyOperationP9JSContext4JSOpN2JS6HandleINS2_5ValueEEENS3_I4jsidEES5_
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:259
  34:     0x7fffe967e1a6 - _ZL9InterpretP9JSContextRN2js8RunStateE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:2712
  35:     0x7fffe96752cf - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:403
  36:     0x7fffe968b567 - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:475
  37:     0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502
  38:     0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE
                        at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521
  39:     0x7fffe937d1af - _ZN2JS4CallEP9JSContextNS_6HandleINS_5ValueEEES4_RKNS_16HandleValueArrayENS_13MutableHandleIS3_EE
                        at /z/stylo/hg-incubator/js/src/jsapi.cpp:2830
  40:     0x7fffe554405e - _ZN7mozilla3dom19EventHandlerNonNull4CallEP9JSContextN2JS6HandleINS4_5ValueEEERNS0_5EventENS4_13MutableHandleIS6_EERNS_11ErrorResultE
                        at /z/stylo/hg-incubator/obj/dom/bindings/EventHandlerBinding.cpp:259
  41:     0x7fffe5b8575f - _ZN7mozilla3dom19EventHandlerNonNull4CallIP11nsISupportsEEvRKT_RNS0_5EventEN2JS13MutableHandleINSA_5ValueEEERNS_11ErrorResultEPKcNS0_14CallbackObject17ExceptionHandlingEP13JSCompartment
                        at /z/stylo/hg-incubator/obj/dist/include/mozilla/dom/EventHandlerBinding.h:361
  42:     0x7fffe5b761c0 - _ZN7mozilla14JSEventHandler11HandleEventEP11nsIDOMEvent
                        at /z/stylo/hg-incubator/dom/events/JSEventHandler.cpp:214
  43:     0x7fffe5b60890 - _ZN7mozilla20EventListenerManager18HandleEventSubTypeEPNS0_8ListenerEP11nsIDOMEventPNS_3dom11EventTargetE
                        at /z/stylo/hg-incubator/dom/events/EventListenerManager.cpp:1133
  44:     0x7fffe5b60fbd - _ZN7mozilla20EventListenerManager19HandleEventInternalEP13nsPresContextPNS_11WidgetEventEPP11nsIDOMEventPNS_3dom11EventTargetEP13nsEventStatus
                        at /z/stylo/hg-incubator/dom/events/EventListenerManager.cpp:1286
  45:     0x7fffe5b8af7c - _ZN7mozilla20EventListenerManager11HandleEventEP13nsPresContextPNS_11WidgetEventEPP11nsIDOMEventPNS_3dom11EventTargetEP13nsEventStatus
                        at /z/stylo/hg-incubator/obj/dist/include/mozilla/EventListenerManager.h:374
  46:     0x7fffe5b7dd37 - _ZN7mozilla20EventTargetChainItem11HandleEventERNS_21EventChainPostVisitorERNS_19ELMCreationDetectorE
                        at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:314
  47:     0x7fffe5b58809 - _ZN7mozilla20EventTargetChainItem22HandleEventTargetChainER8nsTArrayIS0_ERNS_21EventChainPostVisitorEPNS_24EventDispatchingCallbackERNS_19ELMCreationDetectorE
                        at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:463
  48:     0x7fffe5b59dde - _ZN7mozilla15EventDispatcher8DispatchEP11nsISupportsP13nsPresContextPNS_11WidgetEventEP11nsIDOMEventP13nsEventStatusPNS_24EventDispatchingCallbackEP8nsTArrayIPNS_3dom11EventTargetEE
                        at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:820
  49:     0x7fffe6f7eef4 - _ZN16nsDocumentViewer12LoadCompleteE8nsresult
                        at /z/stylo/hg-incubator/layout/base/nsDocumentViewer.cpp:1024
  50:     0x7fffe772771c - _ZN10nsDocShell11EndPageLoadEP14nsIWebProgressP10nsIChannel8nsresult
                        at /z/stylo/hg-incubator/docshell/base/nsDocShell.cpp:7571
  51:     0x7fffe77259d2 - _ZN10nsDocShell13OnStateChangeEP14nsIWebProgressP10nsIRequestj8nsresult
                        at /z/stylo/hg-incubator/docshell/base/nsDocShell.cpp:7375
  52:     0x7fffe3f27ccd - _ZN11nsDocLoader19DoFireOnStateChangeEP14nsIWebProgressP10nsIRequestRi8nsresult
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:1255
  53:     0x7fffe3f277a8 - _ZN11nsDocLoader18doStopDocumentLoadEP10nsIRequest8nsresult
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:840
  54:     0x7fffe3f2626e - _ZN11nsDocLoader16DocLoaderIsEmptyEb
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:730
  55:     0x7fffe3f271ab - _ZN11nsDocLoader13OnStopRequestEP10nsIRequestP11nsISupports8nsresult
                        at /z/stylo/hg-incubator/uriloader/base/nsDocLoader.cpp:612
  56:     0x7fffe2c4798e - _ZN7mozilla3net11nsLoadGroup13RemoveRequestEP10nsIRequestP11nsISupports8nsresult
                        at /z/stylo/hg-incubator/netwerk/base/nsLoadGroup.cpp:633
  57:     0x7fffe48a9dcf - _ZN10nsDocument15DoUnblockOnloadEv
                        at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:8622
  58:     0x7fffe48a9b8c - _ZN10nsDocument13UnblockOnloadEb
                        at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:8550
  59:     0x7fffe489ab72 - _ZN10nsDocument27DispatchContentLoadedEventsEv
                        at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:5058
  60:     0x7fffe4928d19 - _ZN7mozilla6detail23RunnableMethodArgumentsIJEE9applyImplI10nsDocumentMS4_FvvEJEJEEEDTcldsdefp_fp0_spcldtcl3GetIXT2_EEfp1_E15PassAsParameterEEEPT_T0_RNS_5TupleIJDpT1_EEENS_13IndexSequenceIJXspT2_EEEE
                        at /z/stylo/hg-incubator/obj/dist/include/nsThreadUtils.h:791
  61:     0x7fffe4928c98 - _ZN7mozilla6detail23RunnableMethodArgumentsIJEE5applyI10nsDocumentMS4_FvvEEEDTcl9applyImplfp_fp0_dtdefpT10mArgumentscvNS_13IndexSequenceIJEEE_EEEPT_T0_
                        at /z/stylo/hg-incubator/obj/dist/include/nsThreadUtils.h:797
  62:     0x7fffe4928b21 - _ZN7mozilla6detail18RunnableMethodImplIM10nsDocumentFvvELb1ELb0EJEE3RunEv
                        at /z/stylo/hg-incubator/obj/dist/include/nsThreadUtils.h:826
  63:     0x7fffe2ad0ca7 - _ZN8nsThread16ProcessNextEventEbPb
                        at /z/stylo/hg-incubator/xpcom/threads/nsThread.cpp:1213
  64:     0x7fffe2b505fb - _Z19NS_ProcessNextEventP9nsIThreadb
                        at /z/stylo/hg-incubator/xpcom/glue/nsThreadUtils.cpp:381
  65:     0x7fffe33cb0e8 - _ZN7mozilla3ipc11MessagePump3RunEPN4base11MessagePump8DelegateE
                        at /z/stylo/hg-incubator/ipc/glue/MessagePump.cpp:96
  66:     0x7fffe33296c4 - _ZN11MessageLoop11RunInternalEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:232
  67:     0x7fffe3329644 - _ZN11MessageLoop10RunHandlerEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:225
  68:     0x7fffe332961c - _ZN11MessageLoop3RunEv
                        at /z/stylo/hg-incubator/ipc/chromium/src/base/message_loop.cc:205
  69:     0x7fffe6ad4002 - _ZN14nsBaseAppShell3RunEv
                        at /z/stylo/hg-incubator/widget/nsBaseAppShell.cpp:156
  70:     0x7fffe7cab191 - _ZN12nsAppStartup3RunEv
                        at /z/stylo/hg-incubator/toolkit/components/startup/nsAppStartup.cpp:283
  71:     0x7fffe7da48ab - _ZN7XREMain11XRE_mainRunEv
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4485
  72:     0x7fffe7da5395 - _ZN7XREMain8XRE_mainEiPPcPK12nsXREAppData
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4618
  73:     0x7fffe7da5b6e - XRE_main
                        at /z/stylo/hg-incubator/toolkit/xre/nsAppRunner.cpp:4709
  74:           0x40633e - _ZL7do_mainiPPcS0_P7nsIFile
                        at /z/stylo/hg-incubator/browser/app/nsBrowserApp.cpp:328
  75:           0x405a61 - main
                        at /z/stylo/hg-incubator/browser/app/nsBrowserApp.cpp:461
  76:     0x7ffff6d6c82f - __libc_start_main
  77:           0x4058f8 - _start
dom/html/crashtests/395340-1.html
layout/base/crashtests/403245-1.html
layout/base/crashtests/416107.xhtml
layout/base/crashtests/420219-1.html
layout/base/crashtests/455623-1.html
layout/base/crashtests/691118-1.html
layout/base/crashtests/725535.html
layout/base/crashtests/727601.html
layout/base/crashtests/788360.html
layout/generic/crashtests/397844-1.xhtml
layout/generic/crashtests/397844-2.xhtml
layout/generic/crashtests/400223-1.html
layout/generic/crashtests/403143-1.html
layout/generic/crashtests/411835.html
layout/generic/crashtests/437156-1.html
layout/generic/crashtests/444861-1.html
layout/generic/crashtests/448996-1.html
layout/generic/crashtests/514800-1.html
layout/generic/crashtests/673770.html
Summary: stylo: dom/html/crashtests/395340-1.html panics with "got unknown property name from Gecko: ()" → stylo: several tests panic with "got unknown property name from Gecko: ()"
layout/style/crashtests/1074651-1.html
layout/svg/crashtests/459666-1.html
layout/svg/crashtests/789390-1.html
layout/tables/crashtests/404301-1.xhtml
layout/xul/crashtests/397293.xhtml
layout/style/crashtests/456196.html
layout/style/crashtests/1277908-1.html
This one looks straightforward and should unblock about 30 tests. Putting it on Manish's pile for now, but feel free to punt it if this is too many. :-)
Flags: needinfo?(manishearth)
This was fixed by xidorn in https://github.com/servo/servo/commit/e73bb054c559ff5a0731d33b0806cfcbd9425033#diff-b7611dde2809bb07d05c81111b7fc93aR659

If we fail property id parsing we now bail out of the Servo_* call early.
Assignee: nobody → xidorn+moz
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(manishearth)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.