If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Conflict SHLoadLibraryFromKnownFolder when bumping up to WINVER=0x601

RESOLVED FIXED in Firefox 53

Status

()

Core
XPCOM
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
When setting WINVER=0x601, we cannot compile SpecialSystemDirectory.cpp due to the following.

 0:13.17 c:/Development/hg.mozilla.org/mozilla-inbound/xpcom/io/SpecialSystemDirectory.cpp(123): error C2084: function 'HRESULT SHLoadLibraryFromKnownFolder(const KNOWNFOLDERID &,DWORD,const IID &,void **)' already has a body
 0:13.17 C:\Program Files (x86)\Windows Kits\10\include\10.0.14393.0\um\shobjidl.h(32834): note: see previous definition of 'SHLoadLibraryFromKnownFolder'
 0:13.17 c:/Development/hg.mozilla.org/mozilla-inbound/xpcom/io/SpecialSystemDirectory.cpp(158): error C2440: 'initializing': cannot convert from 'HRESULT (__cdecl *)(const KNOWNFOLDERID &,DWORD,const IID &,void **)' to 'HRESULT'
 0:13.17 c:/Development/hg.mozilla.org/mozilla-inbound/xpcom/io/SpecialSystemDirectory.cpp(158): note: There is no context in which this conversion is possible
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8819122 [details]
Bug 1323695 - Conflict SHLoadLibraryFromKnownFolder when bumping up to WINVER=0x0601.

https://reviewboard.mozilla.org/r/98960/#review99222

Why can we not just delete this code after bumping `WINVER`?  Seems like we ought to be able to just get rid of it...
Attachment #8819122 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 3

9 months ago
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8819122 [details]
> Bug 1323695 - Conflict SHLoadLibraryFromKnownFolder when bumping up to
> WINVER=0x0601.
> 
> https://reviewboard.mozilla.org/r/98960/#review99222
> 
> Why can we not just delete this code after bumping `WINVER`?  Seems like we
> ought to be able to just get rid of it...

We don’t decide that WINVER sets 0x0601 yet even if installer drops XP and Vista support.  After build system drops XP and Vista support (it means WINVER becomes 0x0601 and set -subsystem:6.01 for linker), we will remove old code for XP and Vista.

Comment 4

9 months ago
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/6da766edcce8
Conflict SHLoadLibraryFromKnownFolder when bumping up to WINVER=0x0601. r=froydnj
(In reply to Makoto Kato [:m_kato] from comment #3)
> We don’t decide that WINVER sets 0x0601 yet even if installer drops XP and
> Vista support.  After build system drops XP and Vista support (it means
> WINVER becomes 0x0601 and set -subsystem:6.01 for linker), we will remove
> old code for XP and Vista.

And build system peers said they will not drop the build system support until we remove the old code for XP and Vista.

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6da766edcce8
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

9 months ago
Blocks: 1325299

Updated

9 months ago
No longer blocks: 1130266
You need to log in before you can comment on or make changes to this bug.