Closed
Bug 1323741
Opened 8 years ago
Closed 6 years ago
Define CAN_DRAW_IN_TITLEBAR in a single central place
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: Gijs, Unassigned)
References
Details
For some reason we have the same define in at least 4 different places: browser/base/moz.build browser/components/customizableui/moz.build and the Windows and OS X browser themes. When I added it to the themes in bug 1322701, trying to add it only to browser/themes/moz.build didn't seem to work. I'm not sure why. :glandium, is there a way to add the define in browser/moz.build and have it take effect everywhere?
Flags: needinfo?(mh+mozilla)
Comment 1•7 years ago
|
||
Sorry for the late reply. Not at the moment, although that could be a nice addition to export() that is available in moz.build.
Flags: needinfo?(mh+mozilla)
Comment 2•7 years ago
|
||
The only global way to define defines at the moment is to do that in configure.
Comment 3•7 years ago
|
||
Another option is to declare a template in browser/moz.build, and use the template in the browser/*/moz.build, but that's not automatic.
Comment 4•6 years ago
|
||
CAN_DRAW_IN_TITLEBAR doesn't exist in tree anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•