Closed Bug 1323834 Opened 3 years ago Closed 3 years ago

Optimize some of the device blocklisting checks

Categories

(Core :: Graphics, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: milan, Assigned: milan)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

When checking against the blocklist, we query the device information each time through the loop.  No good reason to do that.  See GfxInfoBase::FindBlocklistedDeviceInList
Priority: -- → P5
Whiteboard: [gfx-noted]
Comment on attachment 8819395 [details]
Bug 1323834: Evaluate some information outside the loop, then use it repeatedly.

https://reviewboard.mozilla.org/r/99186/#review99978
Attachment #8819395 - Flags: review?(dvander) → review+
Assignee: nobody → milan
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f40b745a669
Evaluate some information outside the loop, then use it repeatedly.  r=dvander
Backed out for bustage:

https://hg.mozilla.org/integration/autoland/rev/10e3ea2d5f6bb79d263c5c4a52df59f29959e5be

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0f40b745a66919b09fe289c797a2cb7fd6b9079b
Failure log example: https://treeherder.mozilla.org/logviewer.html#?job_id=8182558&repo=autoland
>  /builds/slave/autoland-l64-00000000000000000/build/src/widget/GfxInfoBase.cpp:675:12: error: unused variable 'driverVersion' [-Werror=unused-variable]
Flags: needinfo?(milan)
Thanks for the backout.  Unused variable strikes again. I'll make sure to do a try before pushing again.
Flags: needinfo?(milan)
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b2df70dde35
Evaluate some information outside the loop, then use it repeatedly.  r=dvander
https://hg.mozilla.org/mozilla-central/rev/4b2df70dde35
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.