1323834 - Optimize some of the device blocklisting checks

Status: RESOLVED FIXED

(Core :: Graphics, defect, P5)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

When checking against the blocklist, we query the device information each time through the loop.  No good reason to do that.  See GfxInfoBase::FindBlocklistedDeviceInList

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1323834: Evaluate some information outside the loop, then use it repeatedly.

Review commit: https://reviewboard.mozilla.org/r/99186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99186/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8819395 [details]
Bug 1323834: Evaluate some information outside the loop, then use it repeatedly.

https://reviewboard.mozilla.org/r/99186/#review99978

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f40b745a669
Evaluate some information outside the loop, then use it repeatedly.  r=dvander

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage:

https://hg.mozilla.org/integration/autoland/rev/10e3ea2d5f6bb79d263c5c4a52df59f29959e5be

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0f40b745a66919b09fe289c797a2cb7fd6b9079b
Failure log example: https://treeherder.mozilla.org/logviewer.html#?job_id=8182558&repo=autoland
>  /builds/slave/autoland-l64-00000000000000000/build/src/widget/GfxInfoBase.cpp:675:12: error: unused variable 'driverVersion' [-Werror=unused-variable]

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks for the backout.  Unused variable strikes again. I'll make sure to do a try before pushing again.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d03894900362375125466cd3797ce4800bd182b

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8819395 [details]
Bug 1323834: Evaluate some information outside the loop, then use it repeatedly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99186/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b2df70dde35
Evaluate some information outside the loop, then use it repeatedly.  r=dvander

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b2df70dde35