1323835 - Replace Firefox with brandShortName in AS welcome panel text

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Andrzej Hunt :ahunt]

From Bug 1319254:

(In reply to Francesco Lodolo [:flod] (mostly out of office until Dec 19) from comment #29)
> Is there a specific reason to hard-code Firefox instead of using
> &brandShortName;?

No good reason, and I should fix this.

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1323835 - Use brandShortName in AS welcome panel insted of "Firefox"

Review commit: https://reviewboard.mozilla.org/r/98918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98918/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8819050 [details]
Bug 1323835 - Use brandShortName in AS welcome panel insted of "Firefox"

https://reviewboard.mozilla.org/r/98918/#review99212

::: mobile/android/base/locales/en-US/android_strings.dtd:857
(Diff revision 1)
>  is simply hidden from the Activity Stream panel. -->
>  <!ENTITY activity_stream_dismiss "Dismiss">
>  <!ENTITY activity_stream_delete_history "Delete from History">
>  
>  <!ENTITY activity_stream_welcome_title "Welcome to your Highlights">
> -<!ENTITY activity_stream_welcome_content "Firefox now creates highlights of things you\'ve discovered on the web so you can find your way back to great articles, videos, bookmarks, and other pages.">
> +<!ENTITY activity_stream_welcome_content "&brandShortName; now creates highlights of things you\'ve discovered on the web so you can find your way back to great articles, videos, bookmarks, and other pages.">

You'll need a new ID at this point, since this is already in mozilla-central
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8819050 [details]
Bug 1323835 - Use brandShortName in AS welcome panel insted of "Firefox"

https://reviewboard.mozilla.org/r/98918/#review99374

See flod's comment about updating the ID. Also feel free to flag flod for review of the updated patch. I've a bunch of things in my list already. :)

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

This happens all the time. I wonder if we could write a lint check for that? ;)

Comment 5

[Andrzej Hunt :ahunt]

(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> This happens all the time. I wonder if we could write a lint check for that?
> ;)

I've filed Bug 1324015 for that - not sure how hard it would be, I'll try to learn some lint.

Comment 6

[Andrzej Hunt :ahunt]

Comment on attachment 8819050 [details]
Bug 1323835 - Use brandShortName in AS welcome panel insted of "Firefox"

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98918/diff/1-2/

Comment 7

[Andrzej Hunt :ahunt]

Comment on attachment 8819050 [details]
Bug 1323835 - Use brandShortName in AS welcome panel insted of "Firefox"

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98918/diff/2-3/

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8819050 [details]
Bug 1323835 - Use brandShortName in AS welcome panel insted of "Firefox"

https://reviewboard.mozilla.org/r/98918/#review99448

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff05a52339bc
Use brandShortName in AS welcome panel insted of "Firefox" r=flod

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ff05a52339bc

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

Tested on latest Nightly build 54.0a1 (2017-02-23) using following devices:
- LG G4 (Android 5.1);
- HTC 10 (Android 6.0.1);
- Asus ZenPad 8 (Android 6.0.1).

"Firefox" was replaced with "Nightly" on the welcome Panel text.

I'm marking this as Verified.