1323838 - Pop-up exception not adding HTTPS on secure website

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Zurd]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161201160049

Steps to reproduce:

See www.advataxes.ca/en/requirements.aspx

A pop-up test will be made, firefox will offer you "Edit Pop-up Blocker Options..." with the website www.advataxes.ca already filled in. If you click Allow it will not work, you need to manually add https:// so it can work.



Expected results:

Firefox should either:
1) add https before www.advataxes.ca or
2) make the pop-up exception work on https website

Comment 1

[:Gijs (he/him)]

(In reply to Zurd from comment #0)
> User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101
> Firefox/50.0
> Build ID: 20161201160049
> 
> Steps to reproduce:
> 
> See www.advataxes.ca/en/requirements.aspx
> 
> A pop-up test will be made, firefox will offer you "Edit Pop-up Blocker
> Options..." with the website www.advataxes.ca already filled in. If you
> click Allow it will not work, you need to manually add https:// so it can
> work.

It seems to work fine for me. A popup shows up and is immediately closed. In the options, the item shows up with "https" as the protocol in the list. How do you determine it "will not work" ? Can you reproduce on a clean profile? ( https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles )

Comment 2

[Masatoshi Kimura [:emk]]

I tried with the clean profile and the problem remains.
Steps to reproduce:
1. Navigate to www.advataxes.ca/en/requirements.aspx. (It will redirect to <https://www.advataxes.ca/en/requirements.aspx> and an infobar will be shown saying "Nightly prevented this site from opening a pop-up window.")
2. Click "Options" button on the infobar.
3. Select "Edit Pop-up Blocker Options...". "Allowed Sites - Pop-ups" dialog will open.
4. Click "Allow" on the "Allowed Sites - Pop-ups" dialog without editing "Address of website:" field.
5. Click "Save Changes". The dialog will close.
6. Navigate to www.advataxes.ca/en/requirements.aspx again.

Actual result:
In step 3, "Address of website:" field will be pre-filled with "www.advataxes.ca". (NOT "https://www.advataxes.ca")
In step 4, "http://www.advataxes.ca" will be added. (NOT "https://www.advataxes.ca")
In step 6, the infobar will be shown again.

Expected result:
In step 3, "Address of website:" field should be pre-filled with "https://www.advataxes.ca".
Or, if "Address of website:" field did not contain the protocol, it should block both http and https.

Comment 3

[Masatoshi Kimura [:emk]]

> it should block both http and https.

Correction: it should unblock both http and https.

Comment 4

[Zurd]

Thank you for making a test with a clean profile.

I should add that it's the same problem both in Linux Mint and Windows 7.

Comment 5

[:Gijs (he/him)]

Oh, right, I had misread, and assumed the problem was with the more obvious option in the dropdown "allow popups for ...", which worked fine. I agree the dialog one needs a little tweak. I'll do up a quick patch to fix that and some other minor issues here.

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1323838 - make allowing popups work better,

Review commit: https://reviewboard.mozilla.org/r/99272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99272/

Comment 7

[:Gijs (he/him)]

So, this patch fixes a few things:

1) clicking the "Allow popups for X" option for file:/// URLs (currently allows the filename, which doesn't work - need to use the principal URI)
2) clicking that option on a data: URI created by a webpage (again, need to use the principal URI)
3) the bug reported here, by including the protocol in the string we prefill in the dialog
4) similar bugs to (1) and (2) with the code for (3), now that it sends in a full string rather than just a host.

Comment 8

[Zurd]

On both my Linux and Windows machine the option "Allow pop-ups for..." are greyed out. Cannot use it. Why would that be?

Comment 9

[:Gijs (he/him)]

(In reply to Zurd from comment #8)
> On both my Linux and Windows machine the option "Allow pop-ups for..." are
> greyed out. Cannot use it. Why would that be?

I don't know, but please file a new bug, and see if you can reproduce *that* in a new profile. Thanks! :-)

Comment 10

[Zurd]

Ok it's greyed out because I'm in Private mode. Bug is already filled:
https://bugzilla.mozilla.org/show_bug.cgi?id=970675

Comment 11

[:Gijs (he/him)]

Comment on attachment 8819571 [details]
Bug 1323838 - make allowing popups work better,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99272/diff/1-2/

Comment 12

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8819571 [details]
Bug 1323838 - make allowing popups work better,

https://reviewboard.mozilla.org/r/99272/#review99864

Comment 13

[:Gijs (he/him)]

I've been neglecting landing this because I think it needs one more minor change to use .spec instead of .directory in the fillPopupList code as well... needinfo so I don't forget.

Comment 14

[:Gijs (he/him)]

Comment on attachment 8819571 [details]
Bug 1323838 - make allowing popups work better,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99272/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f2a7d07ce6d
make allowing popups work better, r=Felipe

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3f2a7d07ce6d

Comment 17

[Fahima Zulfath]

BugDay-20170118
Browser:Firefox 53.0
OS:Windows 10
 -Bug verified.