1323923 - Fix -Wunknown-warning-option clang warning in gfx/cairo

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: part-1-fix-Wunknown-warning-option-warning.patch

Bug 1306640 suppressed some -Wunused-but-set-variable gcc warnings. However, -Wunused-but-set-variable is not a clang warning, so clang warns about the unknown -Wno-unused-but-set-variable flag. The confusion comes from GNU_CC being defined for both gcc and clang in moz.build.

> warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option]

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-2-suppress-clang-warnings.patch

If we're going to suppress some clang and gcc warnings in the third-party Cairo code, we might as well suppress them all. :)

Part 2: Suppress more clang warnings and unify CLANG_CXX/CLANG_CL warning flags in gfx/cairo:

gfx/cairo/cairo/src/cairo-image-surface.c:1225:35 [-Wabsolute-value] using floating point absolute value function 'fabs' when argument is of integer type
gfx/cairo/cairo/src/cairo-image-surface.c:1227:35 [-Wabsolute-value] using floating point absolute value function 'fabs' when argument is of integer type
gfx/cairo/cairo/src/cairo-quartz-surface.c:1919:12 [-Wunreachable-code] code will never be executed
gfx/cairo/cairo/src/cairo-quartz-surface.c:1920:6 [-Wunreachable-code] code will never be executed
gfx/cairo/cairo/src/cairo-quartz-surface.c:3530:18 [-Wunused-variable] unused variable 'i'
gfx/cairo/cairo/src/cairo-version.c:39:9 [-Wmacro-redefined] 'CAIRO_VERSION_H' macro redefined

Comment 2

[Chris Peterson [:cpeterson]]

Thanks for the quick review, Lee!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58701d19071d
Part 1: Fix -Wunknown-warning-option clang warning in gfx/cairo. r=lsalzman
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddb057be5d8c
Part 2: Suppress more clang warnings and unify CLANG_CXX/CLANG_CL warning flags in gfx/cairo. r=lsalzman

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/58701d19071d
https://hg.mozilla.org/mozilla-central/rev/ddb057be5d8c