1323929 - Change the reject value type from nsresult to MediaResult

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/09ae31fddfbc229ef1b8f1a3ccd87ad05680e695/dom/media/MediaDecoderReader.h#73

To be consistent with that of MediaTrackDemuxer::SeekPromise.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1323929 - Change the reject value type from nsresult to MediaResult.

Review commit: https://reviewboard.mozilla.org/r/99066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99066/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8819196 [details]
Bug 1323929 - Change the reject value type from nsresult to MediaResult.

https://reviewboard.mozilla.org/r/99066/#review99304

::: dom/media/MediaDecoderStateMachine.cpp:1116
(Diff revision 1)
>    }
>  
> -  void OnSeekRejected(nsresult aResult) {
> +  void OnSeekRejected(const MediaResult& aError) {
>      mSeekRequest.Complete();
>  
> -    MOZ_ASSERT(NS_FAILED(aResult), "Cancels should also disconnect mSeekRequest");
> +    MOZ_ASSERT(NS_FAILED(aError.Code()), "Cancels should also disconnect mSeekRequest");

NS_FAILED(aError) will work

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8819196 [details]
Bug 1323929 - Change the reject value type from nsresult to MediaResult.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99066/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd98f539dad2
Change the reject value type from nsresult to MediaResult. r=jya

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dd98f539dad2