Closed Bug 1323941 Opened 3 years ago Closed 3 years ago

IsPerformanceTimingAttribute() should return false in workers

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1322292#c14
Assignee: nobody → amarchesini
Blocks: 1322292
Attached patch performance4.patch (obsolete) — Splinter Review
I guess this is what you meant.
Flags: needinfo?(bzbarsky)
Comment on attachment 8819224 [details] [diff] [review]
performance4.patch

Yep.  Needs a web platform test for mark() and measure() in workers.

You can just ask me for r=, btw....
Flags: needinfo?(bzbarsky)
Attachment #8819224 - Flags: review+
WPT included
Attachment #8819224 - Attachment is obsolete: true
Attachment #8819512 - Flags: review?(bzbarsky)
Summary: IsPerformanceTimingAttribute() should return null in workers → IsPerformanceTimingAttribute() should return false in workers
Comment on attachment 8819512 [details] [diff] [review]
performance4.patch

r=me.  We should have a test for "navigationStart" as the second arg of measure() too, but we just generally need a _lot_ of tests for this stuff.  :(  So don't worry about it for now; maybe file a wpt issue?
Attachment #8819512 - Flags: review?(bzbarsky) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6be7eb833b11
navigationStart should not be exposed to workers as timing attribute, r=bz
https://hg.mozilla.org/mozilla-central/rev/6be7eb833b11
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.