1323946 - Use MOZ_MUST_USE in netwerk/protocol/res

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Subtask of bug 1303701.

Comment 1

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Attachment: Bug 1323946 - Use MOZ_MUST_USE for netwerk/protocol/res

Review commit: https://reviewboard.mozilla.org/r/100058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100058/

Comment 2

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e667e3792439b8b27e8ac6f92922b2478e804b80

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8820575 [details]
Bug 1323946 - Use MOZ_MUST_USE for netwerk/protocol/res

https://reviewboard.mozilla.org/r/100058/#review100688

::: chrome/nsChromeRegistryChrome.cpp:991
(Diff revision 1)
>                            uri);
>      return;
>    }
>  
> -  rph->SetSubstitution(host, resolved);
> +  rv = rph->SetSubstitution(host, resolved);
> +  MOZ_ASSERT(NS_SUCCEEDED(rv));

Similar to above, if NS_FAILED call LogMessageWithContext

::: layout/style/nsLayoutStylesheetCache.cpp:603
(Diff revision 1)
>      if (!handler) {
>        annotation.AppendLiteral("(ResolveURI failed)\n");
>      } else {
>        nsAutoCString resolvedSpec;
> -      handler->ResolveURI(aURI, resolvedSpec);
> +      DebugOnly<nsresult> rv = handler->ResolveURI(aURI, resolvedSpec);
> +      MOZ_ASSERT(NS_SUCCEEDED(rv));

This may fail. I think this would be more appropriate:
```
if (NS_FAILED(rv)) {
annotation.AppendLiteral("(ResolveURI failed rv=)");
annotation.AppendInt(rv);
annotation.AppendLiteral("\n");
}
```

Comment 4

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Comment on attachment 8820575 [details]
Bug 1323946 - Use MOZ_MUST_USE for netwerk/protocol/res

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100058/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c28b3afaa5cd
Use MOZ_MUST_USE for netwerk/protocol/res r=valentin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c28b3afaa5cd