1323960 - [Pointer Event] dynamically inject mochitest helper to pointer event test cases and keep wpt unchanged

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: [Pointer Event] dynamically inject mochitest helper to pointer event test cases to keep test cases the same as wpt

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: Part1: dynamically inject mochitest helper js to test cases

Now the PointerEvent mochitest test cases are copied from PointerEvent wpt test cases with some modifications (in order to run them as mochitests). This patch dynamically injects the helper js (mochitest_support_internal.js) to the test cases so that we can keep the test cases the same as wpt.

Comment 3

[Ming-Chou Shih [:stone]]

Attachment: Part2: copy test cases from testing/web-platform/tests/pointerevents

Comment 4

[Ming-Chou Shih [:stone]]

Attachment: Part3: disable failed test case and remove nit

Although the test case 'pointerevent_setpointercapture_relatedtarget-manual.html' is enabled and run on try server, it's not actually passed. So disable it.

Comment 5

[Ming-Chou Shih [:stone]]

Attachment: Part1: dynamically inject mochitest helper js to test cases

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8820110 [details] [diff] [review]
Part2: copy test cases from testing/web-platform/tests/pointerevents

This is rs+.
This does plenty of other things than just "copy", but everything looks rather mechanical.

I wonder how we should eventually run the tests. It is a bit silly to have wpt and mochitests.

Comment 7

[Ming-Chou Shih [:stone]]

Attachment: Part1: dynamically inject mochitest helper js to test cases. r=smaug.

Updated the patch summary

Comment 8

[Ming-Chou Shih [:stone]]

Attachment: Part2: sync test cases from testing/web-platform/tests/pointerevents. r=smaug

Updated the patch summary

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Part3: disable failed test case and remove nit. r=smaug.

Updated the patch summary

Comment 10

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=556c1cf29c3edcf50feaf04291ab3ca493cd8ca6

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06723029caa1
Part1: dynamically inject mochitest helper js to test cases. r=smaug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a648323bf66e
Part2: sync test cases from testing/web-platform/tests/pointerevents. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcba3e75ca80
Part3: disable failed test case and remove nit. r=smaug.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06723029caa1
https://hg.mozilla.org/mozilla-central/rev/a648323bf66e
https://hg.mozilla.org/mozilla-central/rev/dcba3e75ca80