1323967 - Improve how Worklet tests are written

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: 02_tests.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8819270 [details] [diff] [review]
02_tests.patch

You have some dump()s in the patch. Please remove those


>-  document.body.appendChild(iframe);
>+function setupTest() {
> }
What is this dummy function about?


>-function setupTest() {
>+window.onload = function() {
>+  SimpleTest.waitForExplicitFinish();
Doesn't look right to call waitForExplicitFinish both in parent and child.
Don't we want this only in parent.


>+  return SpecialPowers.pushPrefEnv(
>+    {"set": [["dom.paintWorklet.enabled", true],
>+             ["dom.worklet.enabled", true]]});
> }
> 
>-var cl = new consoleListener();
>-
>-SimpleTest.waitForExplicitFinish();
>-SpecialPowers.pushPrefEnv(
>-  {"set": [["dom.paintWorklet.enabled", true],
>-           ["dom.worklet.enabled", true]]},
>-  function() { loadTest("file_paintWorklet.html"); });
>-
>+function runTest() {
>+  paintWorklet.import("worklet_paintWorklet.js")
>+}
How does this work. We create the global for this page and at that point  dom.paintWorklet.enabled is false. But somehow we then get access to window.paintWorklet here?
... oh this is confusing. We load the same page in iframe, but runTest is only run in an iframe.
Please add some comment somewhere... I guess to each runTest() function. Or rename the function to something which hints where it will be used.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f380b1052f2a
Improve how Worklet tests are written, r=smaug

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f380b1052f2a