1323969 - Toolkit removed the .splitmenu-menuitem rules

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

In bug 1321556, toolkit removed the .splitmenu-menuitem rules. We need to add them in TB because we use them for the AppMenu.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: splitmenu.patch

Added the rules in primaryToolbar.css of Linux and Windows. MacOS has already this rules because they there never in toolkit.

Comment 2

[Jorg K (CEST = GMT+2)]

Given that yesterday we had triple bustage (bug 1323968, bug 1324185 and bug 1324027) I'll look at this when we're up and running again.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8819271 [details] [diff] [review]
splitmenu.patch

Review of attachment 8819271 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

I applied the patch and compared the Hamburger menu with a Daily build of today 2016-12-18. I can see that the items that are "split", that is, have a left text and a right arrow, work OK with the patch but don't work in Daily.

r=jorgk

::: mail/themes/linux/mail/primaryToolbar.css
@@ +336,5 @@
> +  -moz-box-align: center;
> +  max-width: 42em;
> +  color: MenuText;
> +  font: menu;
> +  list-style-image: none;

OK, so adding what was removed here:
https://hg.mozilla.org/mozilla-central/rev/c490f8faff5b#l6.15

@@ +344,5 @@
>  
> +.splitmenu-menuitem[_moz-menuactive="true"] {
> +  color: -moz-menuhovertext;
> +  background-color: -moz-menuhover;
> +}

and here:
https://hg.mozilla.org/mozilla-central/rev/c490f8faff5b#l6.32

@@ +348,5 @@
> +}
> +
> +.splitmenu-menuitem[disabled="true"] {
> +  color: GrayText;
> +}

and here:
https://hg.mozilla.org/mozilla-central/rev/c490f8faff5b#l6.39

::: mail/themes/windows/mail/primaryToolbar.css
@@ +228,5 @@
> +  -moz-box-align: center;
> +  color: MenuText;
> +  font: menu;
> +  list-style-image: none;
> +  -moz-image-region: auto;

I checked the Windows removals from
https://hg.mozilla.org/mozilla-central/rev/c490f8faff5b
as well, I'll spare you the line numbers ;-)

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/c46a741a72139a42eb2001033bead4a3db459c1a