Closed Bug 1323976 Opened 3 years ago Closed 3 years ago

[Pointer Event] The button value of touch generated pointermove event is incorrect

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: stone, Assigned: stone)

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Assignee: nobody → sshih
Attachment #8826531 - Flags: review?(bugs)
Attachment #8826532 - Flags: review?(bugs)
Attachment #8826531 - Flags: review?(bugs) → review+
Comment on attachment 8826532 [details] [diff] [review]
Part2: Refine button and buttons value of WidgetPointerEvent for touch

I assume touchend handling follows what other browsers are doing.
That spec seem to hint about that behavior, but is a bit vague.
Attachment #8826532 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] (review request backlog because of a work week) from comment #3)
> I assume touchend handling follows what other browsers are doing.
> That spec seem to hint about that behavior, but is a bit vague.
Yes. The values of button and buttons are the same as Chrome and Edge.
Updated the patch summary.
Attachment #8826531 - Attachment is obsolete: true
Attachment #8827724 - Flags: review+
Updated the patch summary
Attachment #8826532 - Attachment is obsolete: true
Attachment #8827726 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c73edc36d18
Part 1: Add eNoButton to WidgetMouseEventBase::buttonType. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb75c153034
Part 2: Refine button and buttons value of WidgetPointerEvent for touch. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3c73edc36d18
https://hg.mozilla.org/mozilla-central/rev/3eb75c153034
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.