1323976 - [Pointer Event] The button value of touch generated pointermove event is incorrect

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: Part1: Add eNoButton to WidgetMouseEventBase::buttonType

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: Part2: Refine button and buttons value of WidgetPointerEvent for touch

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8826532 [details] [diff] [review]
Part2: Refine button and buttons value of WidgetPointerEvent for touch

I assume touchend handling follows what other browsers are doing.
That spec seem to hint about that behavior, but is a bit vague.

Comment 4

[Ming-Chou Shih [:stone]]

(In reply to Olli Pettay [:smaug] (review request backlog because of a work week) from comment #3)
> I assume touchend handling follows what other browsers are doing.
> That spec seem to hint about that behavior, but is a bit vague.
Yes. The values of button and buttons are the same as Chrome and Edge.

Comment 5

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bcadf5982189176ecb09dd108aa7f6a3c80dab6

Comment 6

[Ming-Chou Shih [:stone]]

Attachment: Part1: Add eNoButton to WidgetMouseEventBase::buttonType

Updated the patch summary.

Comment 7

[Ming-Chou Shih [:stone]]

Attachment: Part2: Refine button and buttons value of WidgetPointerEvent for touch

Updated the patch summary

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c73edc36d18
Part 1: Add eNoButton to WidgetMouseEventBase::buttonType. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb75c153034
Part 2: Refine button and buttons value of WidgetPointerEvent for touch. r=smaug

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3c73edc36d18
https://hg.mozilla.org/mozilla-central/rev/3eb75c153034