[Pointer Event] The button value of touch generated pointermove event is incorrect

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stone, Assigned: stone)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → sshih
(Assignee)

Comment 1

2 years ago
Created attachment 8826531 [details] [diff] [review]
Part1: Add eNoButton to WidgetMouseEventBase::buttonType
(Assignee)

Comment 2

2 years ago
Created attachment 8826532 [details] [diff] [review]
Part2: Refine button and buttons value of WidgetPointerEvent for touch
(Assignee)

Updated

2 years ago
Attachment #8826531 - Flags: review?(bugs)
(Assignee)

Updated

2 years ago
Attachment #8826532 - Flags: review?(bugs)
Comment on attachment 8826532 [details] [diff] [review]
Part2: Refine button and buttons value of WidgetPointerEvent for touch

I assume touchend handling follows what other browsers are doing.
That spec seem to hint about that behavior, but is a bit vague.
Attachment #8826532 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Olli Pettay [:smaug] (review request backlog because of a work week) from comment #3)
> I assume touchend handling follows what other browsers are doing.
> That spec seem to hint about that behavior, but is a bit vague.
Yes. The values of button and buttons are the same as Chrome and Edge.
(Assignee)

Comment 6

2 years ago
Created attachment 8827724 [details] [diff] [review]
Part1: Add eNoButton to WidgetMouseEventBase::buttonType

Updated the patch summary.
Attachment #8826531 - Attachment is obsolete: true
Attachment #8827724 - Flags: review+
(Assignee)

Comment 7

2 years ago
Created attachment 8827726 [details] [diff] [review]
Part2: Refine button and buttons value of WidgetPointerEvent for touch

Updated the patch summary
Attachment #8826532 - Attachment is obsolete: true
Attachment #8827726 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 8

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c73edc36d18
Part 1: Add eNoButton to WidgetMouseEventBase::buttonType. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb75c153034
Part 2: Refine button and buttons value of WidgetPointerEvent for touch. r=smaug
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c73edc36d18
https://hg.mozilla.org/mozilla-central/rev/3eb75c153034
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.