132398 - Bad build dependency in module/libpr0n

Status: RESOLVED WORKSFORME

(SeaMonkey :: Build Config, defect)

Description

[Mike Kaply [:mkaply]]

We're working on an icon decoder for OS/2 and we found a bad build dependency.

If you gmake clean in the icon directory and then gmake, it won't build. You 
actually have to build from the decoders directory.

The problem is that the icon directory has a dependency on a lib in the win 
directory, but it doesn't build it before it links.

Comment 1

[hacker formerly known as [e-mail]]

Right, that's why we build icon/win before icon.  

Comment 2

[Mike Kaply [:mkaply]]

decoders has icon/win and then icon, so it works correctly with a 
toplevel build.

in the icon directory itself, it does not build win first because DIRS 
is processed after icon.

Maybe the solution for this is to do what uriloader/exthandler does 
which is not to have makefiles for the platform directories and to put 
the platform directory in the VPATH?

Note I don't have a windows gmake build, I am trying to create the 
icon decoder for Os/2 and running into this problem.

The other issue is that the Makefile in icon has hardcoded win in 
three places - this would solve that problem as well.

Comment 3

[Vedran Miletic]

retargeting

Comment 4

[Mike Kaply [:mkaply]]

This doesn't seem to be a problem anymore. I can make clean and make in icon
directory no prob.