1323994 - Start using node 6 in prod for addons-linter and addons-frontend projects

Status: RESOLVED FIXED

(Cloud Services :: Operations: AMO, task)

Description

[Stuart Colville [:muffinresearch]]

Node 6 became the current LTS in October 2016, since we've been testing and developing under node 6 for a while we should be good to switch over to running both the addons-linter and addons-frontend projects under node 6 in production.

Whilst there's no immediate rush it would be good to fit this into Q1 2017 if possible.

Comment 1

[Stuart Colville [:muffinresearch]]

See also https://github.com/mozilla/addons-frontend/issues/1120 and https://github.com/mozilla/addons-linter/issues/945

Comment 2

[Jason Thomas [:jason]]

addons-frontend has been updated. We still need to make changes for addons-linter, :wezhou will handle.

Comment 3

[:wezhou]

It turns out addons-linter has been using node 6 since January. Our upstream, EPEL, must have updated its version back then.

$ sudo docker run --rm hub.prod.mozaws.net/pipelines/addons-server:latest rpm -qi nodejs
Name        : nodejs
Epoch       : 1
Version     : 6.9.4
Release     : 2.el7
Architecture: x86_64
Install Date: Wed 15 Mar 2017 04:58:41 PM UTC
Group       : Development/Languages
Size        : 16665448
License     : MIT and ASL 2.0 and ISC and BSD
Signature   : RSA/SHA256, Thu 19 Jan 2017 07:29:30 PM UTC, Key ID 6a2faea2352c64e5
Source RPM  : nodejs-6.9.4-2.el7.src.rpm
Build Date  : Thu 19 Jan 2017 02:42:18 PM UTC
Build Host  : buildhw-06.phx2.fedoraproject.org
Relocations : (not relocatable)
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : http://nodejs.org/
Summary     : JavaScript runtime

Comment 4

[Jason Thomas [:jason]]

If we aren't using nodesource anymore we should remove it from https://github.com/mozilla/addons-server/blob/master/Dockerfile.deploy#L11 and other places.