1323996 - "COMPtrTypes.h(17): error C2371: 'mozilla::a11y::IAccessibleHolder': redefinition; different basic types" with --disable-accessibility

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

10:07.93 c:\Users\Ryan\repos\mozilla-central\objdir-fx-64\dist\include\mozilla/a11y/COMPtrTypes.h(17): error C2371: 'mozilla::a11y::IAccessibleHolder': redefinition; different basic types
10:07.94 c:\Users\Ryan\repos\mozilla-central\objdir-fx-64\dist\include\mozilla/a11y/IPCTypes.h(41): note: see declaration of 'mozilla::a11y::IAccessibleHolder'

Fallout from bug 1314707 it appears.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I'm a bit confused about this one since IPCTypes.h seems to have defined(ACCESSIBILITY) guards in place? I did try clobbering to make sure it wasn't some local state issue. It also reproduces on Try.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Which source file(s) were failing to compile due to these errors?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=596deef3d9debbe59537a7cbc8a487b7dbe60f92

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fix

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=138125a6d47b

Comment 6

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8819374 [details] [diff] [review]
Fix

fwiw, it would be easier to review this if the commit message explained why it is needed.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c141ad08e219041aa5505fe925d086e3a93df0b9
Bug 1323996: Make PDocAccessible.ipdl import IAccessibleHolder from IPCTypes.h to fix --disable-accessibility build failures; r=tbsaunde

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c141ad08e219

Comment 9

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8819374 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/Bug causing the regression]: bug 1314707
[User impact if declined]: None. Breaks --disable-accessibility builds
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Depends on bug 1314707 being uplifted
[Is the change risky?]: No
[Why is the change risky/not risky?]: This fix affects non-default build configurations; it does not affect the builds that we ship.
[String changes made/needed]: None

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8819374 [details] [diff] [review]
Fix

followup build fix for bug 1314707, for aurora52

Comment 11

[Carsten Book [:Tomcat]]

had to back this out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=4509730&repo=mozilla-aurora

Comment 12

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3686b2e516446faba229534613cee5e2e2c82258