1324003 - Remove the TELEMETRY_SCHEDULER_SEND_DAILY histogram

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Georg Fritzsche [:gfritzsche]]

The TELEMETRY_SCHEDULER_SEND_DAILY expired and didn't yield any surprising result.
We should remove it and the accompanying code:
https://dxr.mozilla.org/mozilla-central/search?q=TELEMETRY_SCHEDULER_SEND_DAILY

Comment 1

[Vincent Lequertier]

Hi,

can I work on this? :-)

Comment 2

[Chris H-C :chutten]

Please do!

You will need to remove the probe definition from toolkit/components/telemetry/Histograms.json and its use in toolkit/components/telemetry/TelemetrySession.jsm. Then you will need to build the code and test that the resulting firefox works by just seeing if it runs, and by running some tests.

Please let me know if you have any questions.

Comment 3

[Vincent Lequertier]

Attachment: remove_telemetry_scheduler_send_daily.patch

Comment 4

[Chris H-C :chutten]

Comment on attachment 8820035 [details] [diff] [review]
remove_telemetry_scheduler_send_daily.patch

Review of attachment 8820035 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Chris H-C :chutten]

There, that should get it in the build in the next day or two.

Do you require help finding another bug to work on? We have plenty :)

Comment 6

[Vincent Lequertier]

Yes, thanks for that

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c37453397645
Remove TELEMETRY_SCHEDULER_SEND_DAILY; r=chutten

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c37453397645