Closed
Bug 1324020
Opened 8 years ago
Closed 7 years ago
Unreachable code in EnumerableOwnProperties?
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
This line [1] seems to be unreachable, because native objects are always handled in [2]. [1] https://dxr.mozilla.org/mozilla-central/rev/63b447888a6469b9f6ae8f76ac5f0d7c6ea239da/js/src/builtin/Object.cpp#863 [2] https://dxr.mozilla.org/mozilla-central/rev/63b447888a6469b9f6ae8f76ac5f0d7c6ea239da/js/src/builtin/Object.cpp#837
|
||
Comment 1•8 years ago
|
||
Looks like it, yeah. rs=me on removing that |if|.
|
Assignee | |
Comment 2•7 years ago
|
||
Removed the if-statement, rs+ from Waldo per comment #1.
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fc6b5b9267f9 Remove unreachable code in EnumerableOwnProperties function. rs=Waldo
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc6b5b9267f9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•