Closed Bug 1324040 Opened 5 years ago Closed 5 years ago

mozboot: Can't download rustup on Ubuntu 14.04

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

Ben Kelly reported the following failure with ./mach bootstrap installing rust:

URLError: <urlopen error [Errno 1] _ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure>

It seems that older Python 2.7.6 urllib2 doesn't support SNI. I thought using the in-tree `requests` module would work around this, but apparently not.
Assignee: nobody → giles
Comment on attachment 8819351 [details]
Bug 1324040 - mozboot: Download rustup without SNI.

https://reviewboard.mozilla.org/r/99172/#review99462

::: python/mozboot/mozboot/rust.py:15
(Diff revision 1)
> -RUSTUP_URL_BASE = 'https://static.rust-lang.org/rustup'
> +# Use the no-CNAME host for compatibilty with Python 2.7
> +# which doesn't support SNI.
> +RUSTUP_URL_BASE = 'https://static-rust-lang-org.s3.amazonaws.com/rustup'

Nit: maybe "...doesn't support TLS SNI" so that people have an easier time figuring out (i.e. googling/yahooing) what's going on?  I'm not going to insist on this, though.
Attachment #8819351 - Flags: review?(nfroyd) → review+
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1d3e2d6c2b8
mozboot: Download rustup without SNI. r=froydnj
For what it’s worth, Python 2.7.9 (released on 2014-12-10) and later support SNI natively.

There’s also a way to make Requests send SNI on older Python, but that requires enough dependency that it’s probably not very helpful for the purpose of `./mach bootstrap`:

https://stackoverflow.com/questions/18578439/using-requests-with-tls-doesnt-give-sni-support/18579484#18579484
Good to know. I think this is a better fix than adding the required dependencies.
https://hg.mozilla.org/mozilla-central/rev/f1d3e2d6c2b8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.