1324050 - Optimize PNG data in search plugin files

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P3)

Description

[Francesco Lodolo [:flod]]

Once bug 1324045 lands, and we have all files de-duplicated in a single folder, we should look into optimizing PNG data used for icons.

In some cases the result is really small (e.g. en-US icons), in other it's almost half kB. Given that we fight to keep the apk size low, it sounds like a good thing to do (kudos to Pike for noticing it).

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1324050 - Optimize PNG data in mobile searchplugins

Also rename Wikipedia Belarusian for consistency

Review commit: https://reviewboard.mozilla.org/r/126362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126362/

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Image comparison

Comment 3

[Francesco Lodolo [:flod]]

Difference in size (uncompressed) is about –38%

Comment 4

[Mike Kaply [:mkaply]]

I don't see a list.json change for the wikipedia belarusian?

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #4)
> I don't see a list.json change for the wikipedia belarusian?

It's right below the commit message
https://docs.google.com/document/d/1N7SrfS8_PGfQFsfBztrDXy8UfvOVUzT3bgBhZxwBNOU/edit

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 8854433 [details]
Bug 1324050 - Optimize PNG data in mobile searchplugins

https://reviewboard.mozilla.org/r/126362/#review128904

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b69ae3719796
Optimize PNG data in mobile searchplugins r=mkaply

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b69ae3719796

Comment 9

[Francesco Lodolo [:flod]]

There was a spike right before this landed on single locale builds
Δ 324468.0 (0.9%)

The spike for multilocale was
Δ 165509.0 (0.4%)

So I assume the gain for multilocale builds should be around 160 kB.

We're going to add a lot of locales on Nightly (bug 1353507), so the next measurement is not going to be helpful to confirm this change.