Add new telemetry probe for excessively long GPU process initialisation time

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gw280, Assigned: gw280)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

We have an existing probe, GPU_PROCESS_LAUNCH_TIME_MS_2, which tracks the total launch time for the GPU process including initialisation and the actual process start.

I think we're going to need another one just to track the various initialisation stuff independent of how long we effectively take to fork.
(Assignee)

Updated

2 years ago
Blocks: 1307578

Updated

2 years ago
Whiteboard: [gfx-noted]
Created attachment 8820555 [details] [diff] [review]
0001-Bug-1324095-Add-GPU_PROCESS_INITIALIZATION_TIME_MS-t.patch

I debated whether to include XPCOM initialisation time in this probe, and I don't think it's valuable to us. This should really be tracking GPU-process-specific work that's being done during initialisation I think.
Assignee: nobody → gwright
Attachment #8820555 - Flags: review?(dvander)
Attachment #8820555 - Flags: review?(dvander) → review+
(Assignee)

Updated

2 years ago
Attachment #8820555 - Flags: feedback?(benjamin)

Comment 2

2 years ago
Comment on attachment 8820555 [details] [diff] [review]
0001-Bug-1324095-Add-GPU_PROCESS_INITIALIZATION_TIME_MS-t.patch

argh, I thought I marked this last week; I apologize for the delay.

I do think we should commit to monitoring this permanently, but I don't think we have yet a good way to do that. Please work with RyanVMs team so that we can have the right automated alerting set up for this.
Flags: needinfo?(ryanvm)
Attachment #8820555 - Flags: feedback?(benjamin) → feedback+

Comment 3

2 years ago
Pushed by gwright@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db66457631b6
Add GPU_PROCESS_INITIALIZATION_TIME_MS to track how long the GPU process takes to initialise excluding fork/xpcom initialisation times r=dvander,data-review=bsmedberg

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db66457631b6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Flags: needinfo?(ryanvm)
You need to log in before you can comment on or make changes to this bug.